Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect and tag flaky tests #7832

Merged
merged 1 commit into from Nov 15, 2023
Merged

Conversation

srbarrios
Copy link
Member

@srbarrios srbarrios commented Nov 6, 2023

What does this PR change?

Related to:

Flaky tests: Those that have not a consistent result, and sometimes are failing and others are passing.

When we review a Test Report in a Pull Request, we would like to identify which of the test features or scenarios we are reviewing has been failing intermittently in the past, which will facilitate a comparison of results between our PR and the main branch.

To address that we want to:

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests

  • DONE

Links

Ports:

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

github-actions bot commented Nov 6, 2023

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7832/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7832/checks.
See the troubleshooting guide if you need any help.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@srbarrios srbarrios marked this pull request as ready for review November 6, 2023 14:53
@srbarrios srbarrios requested a review from a team as a code owner November 6, 2023 14:53
@srbarrios srbarrios force-pushed the qe-collect-inject-flaky-test-tags branch 9 times, most recently from e1f6d08 to df598c9 Compare November 8, 2023 16:04
@jordimassaguerpla
Copy link
Contributor

Hi @srbarrios ! In general I like the whole idea! IIUC we do not need any additional hardware or service, but we use the github project ... great idea!

I have a few comments.

what is the GH_TOKEN_GALAXY_CI in GITHUB_TOKEN: ${{ secrets.GH_TOKEN_GALAXY_CI }} ?

I would not add the call to the new rake task into testsuite/podman_runner/05_install_gems_in_controller.sh . I think this is confusing. What about creating a new script? 06_update_flaky_tests.sh? or rename the 05 to 05_install_gems_in_controller_and_update_flaky_tests ...

@srbarrios
Copy link
Member Author

srbarrios commented Nov 9, 2023

what is the GH_TOKEN_GALAXY_CI in GITHUB_TOKEN: ${{ secrets.GH_TOKEN_GALAXY_CI }} ?

This is a secret that probably will only work in branches, but not in forks.
So for now.. I think this will not work on forks, we will need to figure out a different approach on GH Validation for PR of forks.
An option could be to upload daily the flaky tests of our private GH Board to our Redis instance with public read access in cloud, and get the information from there.

I would not add the call to the new rake task into testsuite/podman_runner/05_install_gems_in_controller.sh . I think this is confusing. What about creating a new script? 06_update_flaky_tests.sh? or rename the 05 to 05_install_gems_in_controller_and_update_flaky_tests ...

Indeed.
I was worry about renumbering the current scripts, but if you don't mind, then I will separate the new actions in different scripts.

@srbarrios srbarrios force-pushed the qe-collect-inject-flaky-test-tags branch 5 times, most recently from 01050eb to 6af5ca9 Compare November 10, 2023 10:26
@srbarrios srbarrios force-pushed the qe-collect-inject-flaky-test-tags branch from 6af5ca9 to d120d08 Compare November 10, 2023 10:35
@srbarrios srbarrios merged commit 0fbde7b into master Nov 15, 2023
6 of 9 checks passed
@srbarrios srbarrios deleted the qe-collect-inject-flaky-test-tags branch November 15, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants