Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raspberry Pi OS 12 support #7852

Merged
merged 11 commits into from Nov 30, 2023
Merged

Conversation

raulillo82
Copy link
Contributor

@raulillo82 raulillo82 commented Nov 9, 2023

What does this PR change?

Add Raspbian OS 12 support for both arm64 and armhf architectures.

GUI diff

No difference.

  • DONE

Documentation

Test coverage

  • Cucumber tests to be added later

  • DONE

Links

Implements #7853

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things, but in general the PR looks good.

utils/spacewalk-common-channels Show resolved Hide resolved
utils/spacewalk-common-channels.ini Outdated Show resolved Hide resolved
spacewalk/certs-tools/rhn_bootstrap_strings.py Outdated Show resolved Hide resolved
@raulillo82 raulillo82 requested review from a team as code owners November 10, 2023 13:04
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7852/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7852/checks.
See the troubleshooting guide if you need any help.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@raulillo82
Copy link
Contributor Author

All discussions solved as of now.

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@raulillo82
Copy link
Contributor Author

All discussions solved as of now.
I was told that the documentation was ready to be merged, but I asked to wait till this gets the approval and is merged before (or at the same time at least).
@juliogonzalez , could you have a look?

Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python files look good. It seems Salt preflight script is already taking care of Raspbian.

LGTM, thanks!

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicking from this last review. Feel free to ignore if you want :-)

utils/spacewalk-common-channels.ini Outdated Show resolved Hide resolved
utils/spacewalk-common-channels.ini Outdated Show resolved Hide resolved
@raulillo82 raulillo82 changed the title Raspbian OS 12 support (WIP) Raspberry Pi OS 12 support (WIP) Nov 29, 2023
@raulillo82 raulillo82 changed the title Raspberry Pi OS 12 support (WIP) Raspberry Pi OS 12 support Nov 30, 2023
@raulillo82 raulillo82 merged commit a04d914 into uyuni-project:master Nov 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants