Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Continue the changes for openSUSE MicroOS and Tumbleweed #7858

Merged
merged 2 commits into from Nov 17, 2023

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented Nov 10, 2023

What does this PR change?

This gets both openSUSE MicroOS and Tumbleweed to a basic PoC, but not production-ready.

Still it's good for people that want to give it a try find what else is broken and undetected during my tests, and of course for people that want to contribute with fixes.

See what was tested, what works and what doesn't at https://github.com/uyuni-project/uyuni/wiki/openSUSE-Tumbleweed-and-openSUSE-MicroOS-for-Uyuni

Packages used for testing available at https://build.opensuse.org/project/show/home:juliogonzalezgil:branches:systemsmanagement:Uyuni:Master2

GUI diff

No difference.

  • DONE

Documentation

Test coverage

  • No tests: Will come if the ever stops being a PoC

  • DONE

Links

https://hackweek.opensuse.org/23/projects/testing-gnu-slash-linux-distributions-on-uyuni

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@juliogonzalez juliogonzalez requested a review from a team November 10, 2023 15:30
@juliogonzalez juliogonzalez requested a review from a team as a code owner November 10, 2023 15:30
@juliogonzalez juliogonzalez requested review from meaksh and removed request for a team November 10, 2023 15:30
@@ -159,50 +159,6 @@
"venv-salt-minion",
]

PKGLISTUMBLEWEED_SALT_NO_BUNDLE = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't what the non-bundle package anymore. With the bundle we don't depend on the version Tumbleweed has, so we can always stay compatible with the Salt Master on the Uyuni Server.

{% set osrelease = 'latest' %}
#end of exceptions
{%- if os_base == 'opensusemicroos' or os_base == 'opensusetumbleweed' %}
{% set osrelease = 'latest/0' %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 is the minor release. Used for the bootstrap script and preflight script.

Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. I think it's ok to use these repos as a source of the bundle for TW and MicroOS for PoC.

Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix sent for a comment typo. For the rest, it looks good to me.

susemanager-utils/susemanager-sls/salt-ssh/preflight.sh Outdated Show resolved Hide resolved
Co-authored-by: Raúl Osuna <raulosuna@gmail.com>
Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliogonzalez juliogonzalez merged commit 8e9555b into uyuni-project:master Nov 17, 2023
9 of 11 checks passed
@juliogonzalez juliogonzalez deleted the tumbleweed-microos branch November 17, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants