New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Continue the changes for openSUSE MicroOS and Tumbleweed #7858
[PoC] Continue the changes for openSUSE MicroOS and Tumbleweed #7858
Conversation
67a92c0
to
979c00d
Compare
@@ -159,50 +159,6 @@ | |||
"venv-salt-minion", | |||
] | |||
|
|||
PKGLISTUMBLEWEED_SALT_NO_BUNDLE = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't what the non-bundle package anymore. With the bundle we don't depend on the version Tumbleweed has, so we can always stay compatible with the Salt Master on the Uyuni Server.
{% set osrelease = 'latest' %} | ||
#end of exceptions | ||
{%- if os_base == 'opensusemicroos' or os_base == 'opensusetumbleweed' %} | ||
{% set osrelease = 'latest/0' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0
is the minor release. Used for the bootstrap script and preflight script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me. I think it's ok to use these repos as a source of the bundle for TW and MicroOS for PoC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small fix sent for a comment typo. For the rest, it looks good to me.
Co-authored-by: Raúl Osuna <raulosuna@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR change?
This gets both openSUSE MicroOS and Tumbleweed to a basic PoC, but not production-ready.
Still it's good for people that want to give it a try find what else is broken and undetected during my tests, and of course for people that want to contribute with fixes.
See what was tested, what works and what doesn't at https://github.com/uyuni-project/uyuni/wiki/openSUSE-Tumbleweed-and-openSUSE-MicroOS-for-Uyuni
Packages used for testing available at https://build.opensuse.org/project/show/home:juliogonzalezgil:branches:systemsmanagement:Uyuni:Master2
GUI diff
No difference.
Documentation
A wiki page for now: https://github.com/uyuni-project/uyuni/wiki/openSUSE-Tumbleweed-and-openSUSE-MicroOS-for-Uyuni
DONE
Test coverage
No tests: Will come if the ever stops being a PoC
DONE
Links
https://hackweek.opensuse.org/23/projects/testing-gnu-slash-linux-distributions-on-uyuni
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: