-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish content for download pdf #38
Comments
change it like we want to have the focus on… Add meta data (Person Date etc.) and Textstyling like the notebook Finish each component so that it looks like in the notebook as the focus of the pdf rest like the on for the notebook Fix also this broken unittests.
|
I created a new bug for the pdf on the test system. |
so this issue is finally only about change the content of the pdf content of pdf should be:
|
As discussed here are the first rough drafts of the PDF of a notebook. One example of Plantation Lives without appendix: One example of Demo Topic with new appendix: @martindusinberre Should we continue with this approach? So we will finalize that. |
Appendix added with commit: 807d96d |
The comment from Ramun was how it would actually look with a lot of inputted data. If I were to do a proper play through, then would you able to see my inputs and turn them into a notebook PDF? If so, I can do that on Wednesday so that you have a lot of dummy text.
|
Thanks for your feedback. To your points:
|
Great. So 1.: in the appendix are images with "zoom" and also with multiple jpgs, with each jpg file appearing as a separate image in the appendix, right? |
for 1: yes, exactly. |
3: good, don't waste time on it! As long as the player name is visible on each notebook page, in that case. Thanks to you all. |
Drafts |
Filename is also changed to match name of the player |
@christian-bernet The notebook is looking really great. My personal preference is for a white background, not grey, as I think it looks cleaner. |
@martindusinberre thanks for your feedback. Give us some time to finish it.... And then I can give you the wished example. |
Draft v3: |
@martindusinberre I think in the draft v3: it shows what you want to see. |
Looks wonderful. Will try it with a full play-through on Friday/weekend and see how it copes with lots of material. Thanks to both of you, Martin |
@martindusinberre Can you have a look at this now and give us some feedback until Monday morning. It should works now on the test system. |
This is almost there. But one problem. Here is a screenshot of my very long notebook entry (to test #25 ) |
And here is the relevant page in the notebook: |
You can see that the right-hand side margins for the notebook entry aren't correctly set in the PDF. |
@Helena-LiT @lfeine Can you also please check the PDF functionality for the notebook and give Christian any feedback before Monday? Thanks, Martin |
thanks. Yes, we can fix that at Monday. |
As mentioned, I'm going to close this issue now as it's basically done. Minor adjustments to the Notebook download PDF will be ticketed as new issues (e.g. the margins one is now #60) |
The content of the notebook pdf is not finished. we need to talk about how should the content should looks like.
Estimate 8 hours
The text was updated successfully, but these errors were encountered: