Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook scrolling with long text #25

Closed
christian-bernet opened this issue Aug 20, 2019 · 17 comments
Closed

notebook scrolling with long text #25

christian-bernet opened this issue Aug 20, 2019 · 17 comments
Assignees
Labels
bug Something isn't working high high priority

Comments

@christian-bernet
Copy link
Contributor

notebook scrolls up when give something in.

@christian-bernet christian-bernet added the bug Something isn't working label Aug 20, 2019
@martindusinberre
Copy link
Collaborator

Yes, this arose in the test: when the player inputs a lot of text in the notebook, it automatically scrolls up. It seems to be a problem with the amount of text inputted (e.g. a long article abstract or a long input from the player).

@christian-bernet
Copy link
Contributor Author

Estimate 2 hours

@martindusinberre martindusinberre added the high high priority label Sep 2, 2019
@martindusinberre
Copy link
Collaborator

Does that mean it's a bug or a settings problem?

@christian-bernet
Copy link
Contributor Author

christian-bernet commented Sep 9, 2019

reproduced on chrome and firefox.
@zlaxi I can show you how!

@martindusinberre
Copy link
Collaborator

Basically: copy and paste a long text into the textExercise component on 2.1.3. Then try to input more text at the bottom of the long text input. You'll see that you keep getting scrolled away from where your cursor is / where you want to input text.

@zlaxi
Copy link

zlaxi commented Sep 12, 2019

@christian-bernet
Copy link
Contributor Author

It is ok now.

@lfeine
Copy link
Collaborator

lfeine commented Sep 13, 2019

This is still happening to me on Firefox 69.0 (OSX). Fixed on my Chrome install though.

@christian-bernet christian-bernet self-assigned this Sep 16, 2019
@christian-bernet
Copy link
Contributor Author

Yes, it is still there fro Firefox on mac osx!

@martindusinberre
Copy link
Collaborator

Still also happening for Safari in Mac OSX (12.1.2)

@zlaxi
Copy link

zlaxi commented Sep 18, 2019

uzh/marugoto-frontend@c70b860 clipboard paste also handled

@zlaxi zlaxi removed their assignment Sep 18, 2019
@christian-bernet
Copy link
Contributor Author

christian-bernet commented Sep 18, 2019

if you hit enter, the fist line is cut off.
Or if you have a long input field it cut on line off at the end.

But it is working on Chrome, Safari and Firefox now.

@martindusinberre
Copy link
Collaborator

I've been testing this (on safari) this morning. It's much better than before. Basically, if the player keeps writing an input, there is no problem at all with scrolling.
The problem only occurs when the player copy and pastes a big amount of text into the notebook (sometimes the game asks the player to do this). In this situation, the scrolling function is broken: it's very difficult to add any text after the pasted text.

@christian-bernet
Copy link
Contributor Author

I tried it also with long text and it works perfect.
image

Can you give me a more detailed description of how to reproduce this bug.
Thanks.

@martindusinberre
Copy link
Collaborator

Perhaps it's a problem with safari? @interrogator would you mind trying to see if it's just a browser problem or a bug? Please see my comment from this morning. Thanks

@interrogator
Copy link
Collaborator

Scroll when typing and pasting both work OK for me on Linux/Firefox.

@martindusinberre
Copy link
Collaborator

OK, great. May be a problem with safari or something else. I'm going to close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high high priority
Projects
None yet
Development

No branches or pull requests

5 participants