Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING #6

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Add CONTRIBUTING #6

merged 1 commit into from
Sep 29, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Sep 28, 2019

No description provided.

@vbrazo vbrazo added the documentation Improvements or additions to documentation label Sep 28, 2019
@vbrazo vbrazo self-assigned this Sep 28, 2019
@vbrazo vbrazo requested a review from dhonx September 28, 2019 21:31
@vbrazo vbrazo changed the title Add contributing Add CONTRIBUTING.md Sep 28, 2019
@vbrazo vbrazo changed the title Add CONTRIBUTING.md Add CONTRIBUTING Sep 28, 2019
@Delta456
Copy link
Member

I think we should also tell people to make a new branch so that it will not mix things up.

dhonx
dhonx approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@dhonx dhonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now 👍.

@dhonx
Copy link
Member

dhonx commented Sep 29, 2019

@Delta456 Good idea ... maybe it's more to recommend them to create new branches for changes rather than make changes in the master branch.

@vbrazo vbrazo merged commit ac8ca13 into master Sep 29, 2019
@vbrazo vbrazo deleted the add-contributing branch September 29, 2019 08:23
Delta456 added a commit that referenced this pull request Nov 5, 2019
@Delta456
Merge pull request #6 from v-community/master
36c7f66 
Take files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhonx dhonx dhonx approved these changes

@Delta456 Delta456 Awaiting requested review from Delta456

Assignees

@vbrazo vbrazo

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbrazo @Delta456 @dhonx