Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema headline wrong encode on cyrillic string #34

Closed
vlntsolo opened this issue Jul 5, 2020 · 1 comment · Fixed by #38
Closed

Schema headline wrong encode on cyrillic string #34

vlntsolo opened this issue Jul 5, 2020 · 1 comment · Fixed by #38

Comments

@vlntsolo
Copy link

vlntsolo commented Jul 5, 2020

Hi, I just tested my post with Cyrillic content with Google testing tool and noticed that flarum-seo encodes description content to headline in schema, so the headline prop duplicates description.
https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Fq.quarks.app%2Fuk%2Fd%2F20-yak-diznatisya-optimalnu-vitratu-resursu

That's strange since description string is parsed and displayed properly.

jaspervriends added a commit that referenced this issue Sep 29, 2020
@jaspervriends
Copy link
Member

I've fixed the headline issue, it should indeed display the discussion title instead of the description. I'll update the extension later today 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants