Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yad-settings doesn't work on systems with default shell being not bash #198

Closed
cherio opened this issue Nov 10, 2022 · 5 comments
Closed

Comments

@cherio
Copy link

cherio commented Nov 10, 2022

I am experiencing this issue in ArchLinux with /bin/sh symlinked to dash.

yad-settings declares itself as a POSIX compatible shell script with shebang #!/bin/sh, however it looks like it is implemented to be bash specific. Since /bin/sh on any system is a symlink which can point to any POSIX compatible shell (it is not required and shouldn't be expected to point to bash), the shebang line should explicitly reference bash, for instance #!/usr/bin/env bash.

@cherio
Copy link
Author

cherio commented Nov 10, 2022

This was originally reported in Arch: https://bugs.archlinux.org/task/76501

@v1cont
Copy link
Owner

v1cont commented Nov 14, 2022

this looks like a bug in autotools. i'm not setting interpreter by hands but set it through AC_PATH_TOOL macro in configure

@cherio
Copy link
Author

cherio commented Nov 14, 2022

I am not an expert in packaging and assembly. I do see the source file yad-settings.in references bash

#! @BASH@
# -*- mode: sh -*-

however the distribution package in Arch contains the script with the first lines looking as

#! /bin/sh
# -*- mode: sh -*-

Do you think the problem is on the distribution (Arch) side? Should Arch build and packaging process change to generate correct shebang?

Sorry, as I said I am not an expert at this.

🇺🇦🇺🇦🇺🇦

@v1cont
Copy link
Owner

v1cont commented Nov 26, 2022

i guess i'd fixed this in v12.1

@cherio
Copy link
Author

cherio commented Nov 26, 2022

Arch main repo already got the fix. Thank you!

@cherio cherio closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants