fix: dns cache with empty response #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loyalsoldier
force-pushed
the
fix_dns_cache_emptyresponse
branch
from
c38f4e9
to
ce2e116
Compare
Loyalsoldier
force-pushed
the
fix_dns_cache_emptyresponse
branch
2 times, most recently
from
bb36949
to
9670d2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 44.82% 44.75% -0.08%
==========================================
Files 485 484 -1
Lines 29494 29477 -17
==========================================
- Hits 13221 13191 -30
- Misses 14872 14884 +12
- Partials 1401 1402 +1
Continue to review full report at Codecov.
|
Loyalsoldier
force-pushed
the
fix_dns_cache_emptyresponse
branch
from
9670d2f
to
b08d67f
Compare
|
The empty response without IP addresses does have error code and other messages in it, we need to store it and detect it later. |
nekohasekai
added a commit
to SagerNet/v2ray-core
that referenced
this pull request
Aug 28, 2021
This reverts commit 73470e8.
AkinoKaede
reviewed
Aug 28, 2021
Comment on lines
-324
to
-325
| if (option.IPv4Enable && record.A != nil) || (option.IPv6Enable && record.AAAA != nil) { | ||
| return nil, dns_feature.ErrEmptyResponse |
There was a problem hiding this comment.
I found a bug that might caused by this changes. The program may wait until the context timeout if the records are empty, and return this error:
[Info] app/dns: failed to lookup ip for domain api.twitter.com at server DOH//9.9.9.9 > context deadline exceeded
[Info] proxy/dns: ip query > app/dns: returning nil for domain api.twitter.com > multierr: context deadline exceeded |
c.c. @Loyalsoldier
There was a problem hiding this comment.
Oh, that's my mistake
xiaokangwang
added a commit
that referenced
this pull request
Sep 4, 2021
This reverts commit 73470e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this provides a fix that the dns app won't do cache with the IPRecord with a empty address (len(rec.IP == 0)).
extensive review is expected @xiaokangwang