Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2565 #19

Closed
wants to merge 3 commits into from
Closed

Fix #2565 #19

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2020 •
edited by ghost

感谢 @xiaokangwang 的修复，我认为在函数中更合适。🙂
fix v2ray/v2ray-core#2565
若有纰漏，请指正！谢谢。

@kslr kslr requested a review from xiaokangwang June 19, 2020 12:58
xiaokangwang
xiaokangwang requested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@xiaokangwang xiaokangwang left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感谢你的贡献。由于你的修改有一些问题，我无法使用这个修改。

从代码的上下文可以看出，UDP的数据包的这个context中包括了请求的目标信息。而同一个UDP代理连接可以把数据发送给不同的目标。如果使用了你的修改的话，那后续数据包的目标信息就没办法正确传递给之后的处理程序了。

@ghost
Copy link
Author

ghost commented Jun 20, 2020

感谢指出，谢谢。

@ghost ghost closed this Jun 20, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

什么时候能解决cpu99+ 打游戏延迟999ms的问题啊
2 participants
@xiaokangwang @JimhHan