Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse for the CipherType of Shadowsocks in simplified config #2510

Merged
merged 2 commits into from Jul 25, 2023

Conversation

AkinoKaede
Copy link
Contributor

@AkinoKaede AkinoKaede commented May 14, 2023

Because UnmarshalJSONPB method is not used for parse enum, I add a wrapper meassage for workaround.
Alternative names added for consistency with previous.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Patch coverage: 3.84% and project coverage change: -0.04 ⚠️

Comparison is base (62bef88) 39.05% compared to head (eda30b2) 39.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2510      +/-   ##
==========================================
- Coverage   39.05%   39.02%   -0.04%     
==========================================
  Files         617      618       +1     
  Lines       37036    37071      +35     
==========================================
  Hits        14466    14466              
- Misses      20978    21013      +35     
  Partials     1592     1592              
Impacted Files Coverage Δ
proxy/shadowsocks/simplified/config.go 2.56% <0.00%> (-0.57%) ⬇️
proxy/shadowsocks/simplified/errors.generated.go 0.00% <0.00%> (ø)
proxy/shadowsocks/simplified/config.pb.go 12.90% <2.63%> (-3.50%) ⬇️
proxy/shadowsocks/config.go 70.89% <33.33%> (+3.51%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AkinoKaede AkinoKaede merged commit d586497 into master Jul 25, 2023
38 of 39 checks passed
@AkinoKaede AkinoKaede deleted the fix-shadowsocks-simplified-cipher-parse branch August 30, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants