Chore: support the new versioning scheme of Protobuf #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobuf has changed their versioning scheme to language-specific one. For Golang, the first version applied the scheme would be 4.21.0 which followed the preceding version,3.20.1. Basically the major part is language-specific and no longer important. Check more: https://protobuf.dev/news/2022-05-06/ protocolbuffers/protobuf#11440 protocolbuffers/protobuf#11123
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2635 +/- ##
==========================================
- Coverage 38.33% 38.28% -0.05%
==========================================
Files 636 637 +1
Lines 38120 38155 +35
==========================================
- Hits 14613 14609 -4
- Misses 21900 21939 +39
Partials 1607 1607
☔ View full report in Codecov by Sentry. |
AkinoKaede
approved these changes
Oct 21, 2023
xiaokangwang
approved these changes
Oct 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf has changed their versioning scheme to a language-specific one. Basically the major part of versioning is now language-specific and no longer important.
Current releases are referred to using the minor version e.g. v24.0. For example, the output of
protoc --versiongiveslibprotoc 24.0-rc3while config.pb.go generated by protoc-gen-go still uses something likev4.24.0--rc3.See also
https://protobuf.dev/news/2022-05-06/
protocolbuffers/protobuf#11440
protocolbuffers/protobuf#11123