Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bump github.com/jhump/protoreflect from 1.15.1 to 1.15.3 #2702

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps github.com/jhump/protoreflect from 1.15.1 to 1.15.3.

Release notes

Sourced from github.com/jhump/protoreflect's releases.

v1.15.3

This is a bugfix release to address a panics in the desc/builder and desc/protoparse packages.

"github.com/jhump/protoreflect/desc/builder"

Changes/fixes:

  • When building an enum where some values in an EnumBuilder had numbers explicitly assigned and others did not, a panic could occur. This panic has now been fixed. When there is a mix of explicit value numbers and implicit numbers, the implicit values will be auto-assigned available numbers (starting at zero) while the explicit values will use the configured number.

"github.com/jhump/protoreflect/desc/protoparse"

Changes/fixes:

  • When the protoparse package was overhauled in v1.15.0, a bug was inadvertently introduced to the functionality related to the Parser.InferImportPaths flag. If the files being processed imported a file for which an AST was not available (which is actually quite common, since they may import a standard file such as "google/protobuf/empty.proto"), a panic would occur. This panic has been fixed.
  • This release includes some other improvements related to the same Parser.InferImportPaths flag which now allow it to better detect file layouts and remedy import mismatches in more scenarios.

v1.15.2

This is a bugfix release to address issues found in the desc/protoparse package.

"github.com/jhump/protoreflect/desc/protoparse"

Changes/fixes:

  • A fix was added to v1.15.1 so that descriptors returned from this package would use statically known extension types for custom options, and custom options in the source that were not statically known would be represented as unrecognized fields. However, the fix was incomplete: only the files whose names were explicitly given to the Parser were updated in this fashion. Other files in the transitive dependency (i.e. imports) did not have options represented this way. As of this release, the fix is complete and all descriptors returned by this package should have the same representation for custom options as in v1.14 and earlier.
  • As of v1.15.0, this package uses the github.com/bufbuild/protocompile package under the hood as the parser. But that package is still using major version zero, since it's API has not completely stabilized. A recent release (v0.6.0) included backwards-incompatible changes that caused this repo to no longer compile. This release addresses the compile errors: this repo now uses that latest release of protocompile and correctly compiles against it.
Commits
  • 35c5957 Fix panic when inferring imports (#575)
  • a276f9d Update README.md to refer to new branch name (#573)
  • 63b3dc8 Fix auto-numbering of values on builder.EnumBuilder (#569)
  • 8baa453 Test with go 1.20 and 1.21, lint with 1.21 (#568)
  • 27addec Update to protocompile v0.6 and grpc-go v1.57.0 to address compatibility issu...
  • 00716cd predeclared does not work with Go 1.20
  • f770609 protoparse should not return dynamic extensions, take 2: must also examine de...
  • 0880b17 build(deps): bump google.golang.org/grpc from 1.38.0 to 1.53.0 (#563)
  • 5556ec8 more clarification in README about state of this repo, v1 vs v2 protobuf API
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 2, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.15.3 branch from 204d368 to 5da2ed6 Compare October 23, 2023 19:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ca8496) 37.77% compared to head (5da2ed6) 37.79%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
+ Coverage   37.77%   37.79%   +0.01%     
==========================================
  Files         654      654              
  Lines       38720    38720              
==========================================
+ Hits        14627    14633       +6     
+ Misses      22482    22477       -5     
+ Partials     1611     1610       -1     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.15.3 branch from 5da2ed6 to a780914 Compare October 23, 2023 19:41
Bumps [github.com/jhump/protoreflect](https://github.com/jhump/protoreflect) from 1.15.1 to 1.15.3.
- [Release notes](https://github.com/jhump/protoreflect/releases)
- [Commits](jhump/protoreflect@v1.15.1...v1.15.3)

---
updated-dependencies:
- dependency-name: github.com/jhump/protoreflect
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/jhump/protoreflect-1.15.3 branch from a780914 to 3f1e4dc Compare October 23, 2023 19:42
@xiaokangwang xiaokangwang merged commit 87492f7 into master Oct 23, 2023
35 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/jhump/protoreflect-1.15.3 branch October 23, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants