Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoDomain to DNS Nameserver in JSONv5 #2711

Merged

Conversation

karelrooted
Copy link
Contributor

Add geoDomain field for DNS's Nameserver in JSONv5 configuration file. This feature was available in the JSONv4 configuration format.

This pull request:

  • Restore the ability to use geoDomain in DNS's Nameserver

Usage:

{
    "address": {
        "address": "8.8.8.8",
        "port": 53
    },
    "geoDomain": [
        {
            "code": "netflix"
        }
    ]
}

@karelrooted karelrooted changed the title Add GeoDomain to JSONv5 DNS Nameserver Add GeoDomain to DNS Nameserver in JSONv5 Oct 9, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (8de2f27) 38.27% compared to head (dfab3c6) 38.24%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2711      +/-   ##
==========================================
- Coverage   38.27%   38.24%   -0.03%     
==========================================
  Files         637      637              
  Lines       38149    38176      +27     
==========================================
  Hits        14600    14600              
- Misses      21939    21965      +26     
- Partials     1610     1611       +1     
Files Coverage Δ
core.go 33.33% <ø> (ø)
...ort/internet/request/roundtripper/httprt/httprt.go 1.36% <ø> (ø)
app/dns/config.pb.go 12.48% <0.00%> (-0.16%) ⬇️
app/dns/dns.go 59.54% <0.00%> (-3.91%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is in general fine. I just have one comment about a unused field in the change.

app/dns/config.proto Outdated Show resolved Hide resolved
@xiaokangwang
Copy link
Contributor

Thanks for your contribution. I think this pull request is ready to be merged.

@xiaokangwang xiaokangwang merged commit cc79bbe into v2fly:master Mar 10, 2024
1 check passed
@xiaokangwang
Copy link
Contributor

This pull request have been merged. Please send a pull request to the document if you are willing and able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants