Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set TTL for incoming UDP IP packets from TUN with PacketAddr dispatcher #2732

Merged
merged 1 commit into from Nov 1, 2023

Conversation

EHfive
Copy link
Contributor

@EHfive EHfive commented Oct 28, 2023

Fixes UDP packets being dropped in non-local routing path(e.g. forwarding to LAN or container veth) due to 0-TTL.

…patcher

Fixes UDP packets being dropped in non-local routing path(e.g. forwarding to LAN or container veth) due to 0-TTL.
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f8d2741) 37.69% compared to head (3de5c5f) 37.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2732      +/-   ##
==========================================
+ Coverage   37.69%   37.70%   +0.01%     
==========================================
  Files         659      659              
  Lines       38874    38876       +2     
==========================================
+ Hits        14653    14658       +5     
+ Misses      22606    22604       -2     
+ Partials     1615     1614       -1     
Files Coverage Δ
app/tun/packetparse/udp.go 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! No issue was discovered, it will be included in v5.11.0 . Thanks for your contribution.

@xiaokangwang xiaokangwang merged commit 42c50d2 into v2fly:master Nov 1, 2023
40 checks passed
@EHfive EHfive deleted the fix-tun-ttl branch November 3, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants