Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new readme #444

Merged
merged 9 commits into from
Nov 22, 2020
Merged

new readme #444

merged 9 commits into from
Nov 22, 2020

Conversation

kslr
Copy link
Contributor

@kslr kslr commented Nov 21, 2020 •
edited
Loading

Screenshot_2020-11-22 kslr kslr(4)

nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
nicholascw
nicholascw reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
Loyalsoldier
Loyalsoldier reviewed Nov 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Loyalsoldier
Copy link
Contributor

lint 我来吧

@Loyalsoldier
Copy link
Contributor

新增了一点东西，这里看效果：https://github.com/Loyalsoldier/testREADME

@Loyalsoldier Loyalsoldier force-pushed the new-readme-design branch 2 times, most recently from 650ed11 to fda3012 Compare November 21, 2020 22:41
@Loyalsoldier
Copy link
Contributor

这个 lint 太奇怪了……

@kslr
Copy link
Contributor Author

kslr commented Nov 22, 2020

能不能简单添加上维护者的信息呢

@kslr kslr requested review from RPRX and nicholascw November 22, 2020 07:27
@kslr
Copy link
Contributor Author

kslr commented Nov 22, 2020

图片

@kslr
Copy link
Contributor Author

kslr commented Nov 22, 2020

这个 lint 太奇怪了……

remarkjs/remark-lint#178 (comment)

@Loyalsoldier
Copy link
Contributor

这个 lint 太奇怪了……

remarkjs/remark-lint#178 (comment)

这个写法太扯了……

@Loyalsoldier
Copy link
Contributor

能不能简单添加上维护者的信息呢

  • macOS:
    • Homebrew: brew install v2ray [package maintainer: @kidonng ]

这样？

@ghost
Copy link

ghost commented Nov 22, 2020

我建议在 README 的 #Installation 节直接链接到 https://www.v2fly.org/guide/install.html
在文档里写 Packagers / Maintainers

@kslr
Copy link
Contributor Author

kslr commented Nov 22, 2020 •
edited
Loading

是的，如果要列的话可能要把所有人列出来 （ 图片现在只有80k了，依旧是png
或者就不写

@kslr
Copy link
Contributor Author

kslr commented Nov 22, 2020

任何变化？

@Loyalsoldier
Copy link
Contributor

在官网文档里添加 maintainer 吧（在项目首页似乎过于高调……

@kslr kslr merged commit bb74ef9 into master Nov 22, 2020
@Loyalsoldier Loyalsoldier deleted the new-readme-design branch November 22, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loyalsoldier Loyalsoldier Loyalsoldier left review comments

@RPRX RPRX Awaiting requested review from RPRX

@nicholascw nicholascw Awaiting requested review from nicholascw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kslr @Loyalsoldier @nicholascw