Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable session resumption by default #569

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Disable session resumption by default #569

merged 1 commit into from
Jan 1, 2021

Conversation

RPRX
Copy link
Contributor

@RPRX RPRX commented Jan 1, 2021

  1. 默认禁用 session resumption，实现与 Golang 的默认 TLS 指纹一致，且不影响 TLSv1.3 的 RTT Deep packet inspection to classify V2Ray traffic in Dec, 2020 #557 (comment)
  2. 移除早已弃用的 allowInsecureCiphers 配置项

kslr
kslr reviewed Jan 1, 2021
View reviewed changes
transport/internet/tls/config.proto
@@ -38,10 +35,10 @@ message Config {
// Lists of string as ALPN values.
repeated string next_protocol = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来这个可以改成 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 在上面，被折叠了

@kslr kslr merged commit 4d2e782 into master Jan 1, 2021
@RPRX RPRX deleted the tls branch January 1, 2021 09:09
@DuckSoft DuckSoft mentioned this pull request Jan 19, 2021
Closed
@1265578519
Copy link

我有个疑问，这个可移除allowInsecureCiphers会导致tls无法使用吗？

@RPRX
Copy link
Contributor Author

RPRX commented Jan 25, 2021

我有个疑问，这个可移除allowInsecureCiphers会导致tls无法使用吗？

亲，allowInsecureCiphers 配置项早就无效了

@1265578519
Copy link

嗯嗯，试了下是和allowInsecure不同的东西，4.34版本还是可以正常使用tls的。
因为要自签域名为baidu.com实现手机5G流量定向免流，所以需要这个功能

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kslr kslr kslr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RPRX @1265578519 @kslr