Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error flow tests #102

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

gtopper
Copy link
Member

@gtopper gtopper commented Nov 7, 2022

The new tests function as regression tests for #100. Without that change, some tests fails on

UnboundLocalError: local variable 'response_body' referenced before assignment

and others on

        for conn in mock_transport.mock_connections:
>           assert conn.times_closed == 0 or conn.times_closed == 1
E           assert (2 == 0
E             +2
E             -0 or 2 == 1
E             +2
E             -1)

(double closing of connections)

@gtopper gtopper requested a review from assaf758 November 7, 2022 06:24
@gtopper gtopper merged commit 71f899c into v3io:development Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants