Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vineyard fails when compiling with Arrow 15.0.0 #1728

Closed
raulcd opened this issue Jan 23, 2024 · 4 comments · Fixed by #1729
Closed

Vineyard fails when compiling with Arrow 15.0.0 #1728

raulcd opened this issue Jan 23, 2024 · 4 comments · Fixed by #1729
Labels
bug Something isn't working

Comments

@raulcd
Copy link

raulcd commented Jan 23, 2024

Describe your problem

I released Arrow 15.0.0 a couple of days ago. I am following up distribution of the package and it seems the Homebrew PR is blocked because Vineyard is not compatible with Arrow 15.0.0: Homebrew/homebrew-core#160553 (comment)

  In file included from /tmp/vineyard-20240122-87256-on1dbr/v6d-0.20.2/modules/basic/ds/arrow_shim/concatenate.cc:67:
  /opt/homebrew/include/arrow/visit_type_inline.h:54:34: error: no matching member function for call to 'Visit'
      ARROW_GENERATE_FOR_ALL_TYPES(TYPE_VISIT_INLINE);
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
  /opt/homebrew/include/arrow/visitor_generate.h:43:3: note: expanded from macro 'ARROW_GENERATE_FOR_ALL_TYPES'
    ACTION(StringView);                           \
    ^~~~~~~~~~~~~~~~~~
  /opt/homebrew/include/arrow/visit_type_inline.h:29:21: note: expanded from macro 'TYPE_VISIT_INLINE'
      return visitor->Visit(internal::checked_cast<const TYPE_CLASS##Type&>(type), \
             ~~~~~~~~~^~~~~
  /tmp/vineyard-20240122-87256-on1dbr/v6d-0.20.2/modules/basic/ds/arrow_shim/concatenate.cc:255:19: note: in instantiation of function template specialization 'arrow::VisitTypeInline<vineyard::arrow_shim::(anonymous namespace)::ConcatenateImpl>' requested here
      RETURN_NOT_OK(VisitTypeInline(*out_->type, this));
                    ^
  /tmp/vineyard-20240122-87256-on1dbr/v6d-0.20.2/modules/basic/ds/arrow_shim/concatenate.cc:260:10: note: candidate function not viable: no known conversion from 'const arrow::StringViewType' to 'const NullType' for 1st argument
    Status Visit(const NullType&) { return Status::OK(); }
           ^

I can't give much details apart from adding compatibility with Arrow 15.

@sighingnow
Copy link
Member

Thanks for reporting. Working on it.

@sighingnow sighingnow added the bug Something isn't working label Jan 23, 2024
sighingnow added a commit that referenced this issue Jan 23, 2024
Fixes #1728

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Copy link
Member

Hi @raulcd, I have just uploaded a new release to github: https://github.com/v6d-io/v6d/releases/tag/v0.20.3.

Please bump up the version of vineyard in homebrew. Thanks!

@raulcd
Copy link
Author

raulcd commented Jan 23, 2024

Thank you very much for the prompt response @sighingnow !

@timsutton
Copy link

Thanks @sighingnow! ❤️

dashanji pushed a commit to dashanji/v6d that referenced this issue Feb 2, 2024
Fixes v6d-io#1728

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
dashanji pushed a commit to dashanji/v6d that referenced this issue Feb 2, 2024
Fixes v6d-io#1728

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants