Add a globalflag --create-namespace for vineyardctl to create the namespace if needed. #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
sighingnow
reviewed
Mar 10, 2023
k8s/cmd/commands/util/namespace.go
Outdated
| log.Fatal(err, "Expects no positional arguments") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It should be ok to put it into util/client.go, as we already have many utils e.g., create/delete, it in.
There was a problem hiding this comment.
Do you mean while creating a resource if the namespace doesn't exist, then create a namespace first?
There was a problem hiding this comment.
I mean no need to put the "CreateNamespace" function into a seperate file, as we already have some similar things in client.go
https://github.com/v6d-io/v6d/blob/main/k8s/cmd/commands/util/client.go
There was a problem hiding this comment.
Got it and resolved. Also, the reference doc updated .
|
🎊 PR Preview 55cb807 has been successfully built and deployed to https://deploy-preview-pr-1243--v6d.netlify.app |
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
sighingnow
reviewed
Mar 10, 2023
sighingnow
reviewed
Mar 10, 2023
sighingnow
reviewed
Mar 10, 2023
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.