[PY-606][external] Added tests for CSV tag uploads #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PY-606 Create tests for uploading csv_tags & csv_tags_video annotations
While working on PY-605, we noticed that introducing support for |
Nathanjp91
reviewed
Dec 7, 2023
| annotation_classes = set( | ||
| [annotation.annotation_class for annotation in annotations] | ||
| ) | ||
| remote_path = "/" + "/".join(filename.split("/")[:-1]) |
There was a problem hiding this comment.
this logic will break on windows because they treat paths with forward slashes will it not? Shouldn't something like pathlib be used
Nathanjp91
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, there were no tests for CSV tags. This meant that breaking changes may have been introduced and tests would not have picked them up
Solution
Introduced tests for CSV tags & CSV video tags
Changelog
Added tests for CSV tag & CSV video tag uploads