-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PY-606][external] Added tests for CSV tag uploads #727
Conversation
PY-606 Create tests for uploading csv_tags & csv_tags_video annotations
While working on PY-605, we noticed that introducing support for |
annotation_classes = set( | ||
[annotation.annotation_class for annotation in annotations] | ||
) | ||
remote_path = "/" + "/".join(filename.split("/")[:-1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this logic will break on windows because they treat paths with forward slashes will it not? Shouldn't something like pathlib be used
Problem
Previously, there were no tests for CSV tags. This meant that breaking changes may have been introduced and tests would not have picked them up
Solution
Introduced tests for CSV tags & CSV video tags
Changelog
Added tests for CSV tag & CSV video tag uploads