Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List numbers overflow on mobile devices #378

Closed
RReverser opened this issue Apr 7, 2020 · 4 comments
Closed

List numbers overflow on mobile devices #378

RReverser opened this issue Apr 7, 2020 · 4 comments
Labels
meta Issues involving the build process or the website itself, rather than its content

Comments

@RReverser
Copy link
Contributor

Looks like once we hit 100 posts, we started overflowing list item numbers for blog posts on mobile viewports, so they end up getting truncated.

Screenshot from DevTools emulation of Pixel 2:

iPhone 5 / SE:

iPhone X:

Also confirmed manually on my Android phone.

@RReverser RReverser added the meta Issues involving the build process or the website itself, rather than its content label Apr 7, 2020
@yozaam
Copy link

yozaam commented Jun 28, 2020

Hello! I am a newcomer but i really want to fix this, I have identified the problem and have signed the CLA, thank you so much:

The "1" of "100" etc is going outside the viewport,
It happens above 200% zooom on desktop / on mobiles < max-width:770px

I will make a small change in main.css and give the offset a slightly greater value such as
--offset: 12px; in this line for screens less than 770 px

The value 12px will give it space for the "1" to come inside the padding:

Currently, the --offset for the padding is too small to accommodate 3 characters:

This is how it will look at 12px:

Screenshot 2020-06-28 at 11 17 46 PM

And like this at 14px: ( so we won't have this issue again after post no. 999 )
Screenshot 2020-06-28 at 11 26 56 PM

Thanks again,
yozaam

yozaam added a commit to yozaam/v8.dev that referenced this issue Jun 28, 2020
List numbers overflow on mobile devices v8#378
@RReverser
Copy link
Contributor Author

@tomayac Could you please help out with review - there are two open PRs (#396 and #430) that fix this issue in different ways, but I don't know enough to tell which one is better.

@tomayac
Copy link
Contributor

tomayac commented Jul 30, 2020

I would go with #396, since it's the more flexible one of the two. Should we later on decide to change the --offset, everything will continue to look right.

@RReverser
Copy link
Contributor Author

Thanks @tomayac, I shall do that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues involving the build process or the website itself, rather than its content
Projects
None yet
Development

No branches or pull requests

3 participants