Skip to content

Commit

Permalink
Rename src/float.h to src/boxed-float.h
Browse files Browse the repository at this point in the history
Apparently the name float.h causes problems on Windows when V8 is
compiled with Visual Studio, see the bug description.

R=clemensh@chromium.org

Bug: v8:6588
Change-Id: Iaa9c1e93e62509a779f1a8ddecbb03a53981cf8a
Reviewed-on: https://chromium-review.googlesource.com/578029
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46791}
  • Loading branch information
gahaas authored and Commit Bot committed Jul 20, 2017
1 parent 4037ad6 commit 5f1157d
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1175,6 +1175,7 @@ v8_source_set("v8_base") {
"src/bit-vector.h",
"src/bootstrapper.cc",
"src/bootstrapper.h",
"src/boxed-float.h",
"src/builtins/builtins-api.cc",
"src/builtins/builtins-array.cc",
"src/builtins/builtins-arraybuffer.cc",
Expand Down Expand Up @@ -1532,7 +1533,6 @@ v8_source_set("v8_base") {
"src/flag-definitions.h",
"src/flags.cc",
"src/flags.h",
"src/float.h",
"src/frames-inl.h",
"src/frames.cc",
"src/frames.h",
Expand Down
2 changes: 1 addition & 1 deletion src/arm/assembler-arm.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@

#include "src/arm/constants-arm.h"
#include "src/assembler.h"
#include "src/boxed-float.h"
#include "src/double.h"
#include "src/float.h"

namespace v8 {
namespace internal {
Expand Down
6 changes: 3 additions & 3 deletions src/float.h → src/boxed-float.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef V8_FLOAT32_H_
#define V8_FLOAT32_H_
#ifndef V8_BOXED_FLOAT_H_
#define V8_BOXED_FLOAT_H_

#include "src/base/macros.h"

Expand Down Expand Up @@ -54,4 +54,4 @@ class Float64 {
} // namespace internal
} // namespace v8

#endif // V8_FLOAT32_H_
#endif // V8_BOXED_FLOAT_H_
2 changes: 1 addition & 1 deletion src/compiler/arm/code-generator-arm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@

#include "src/arm/macro-assembler-arm.h"
#include "src/assembler-inl.h"
#include "src/boxed-float.h"
#include "src/compilation-info.h"
#include "src/compiler/code-generator-impl.h"
#include "src/compiler/gap-resolver.h"
#include "src/compiler/node-matchers.h"
#include "src/compiler/osr.h"
#include "src/double.h"
#include "src/float.h"
#include "src/heap/heap-inl.h"

namespace v8 {
Expand Down
2 changes: 1 addition & 1 deletion src/deoptimizer.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
#define V8_DEOPTIMIZER_H_

#include "src/allocation.h"
#include "src/boxed-float.h"
#include "src/deoptimize-reason.h"
#include "src/float.h"
#include "src/macro-assembler.h"
#include "src/source-position.h"
#include "src/zone/zone-chunk-list.h"
Expand Down
2 changes: 1 addition & 1 deletion src/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@
'bit-vector.h',
'bootstrapper.cc',
'bootstrapper.h',
'boxed-float.h',
'builtins/builtins-api.cc',
'builtins/builtins-arraybuffer.cc',
'builtins/builtins-array.cc',
Expand Down Expand Up @@ -976,7 +977,6 @@
'flag-definitions.h',
'flags.cc',
'flags.h',
'float.h',
'frames-inl.h',
'frames.cc',
'frames.h',
Expand Down
2 changes: 1 addition & 1 deletion test/cctest/test-disasm-arm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
#include <stdlib.h>

#include "src/assembler-inl.h"
#include "src/boxed-float.h"
#include "src/debug/debug.h"
#include "src/disasm.h"
#include "src/disassembler.h"
#include "src/double.h"
#include "src/float.h"
#include "src/macro-assembler.h"
#include "src/objects-inl.h"
#include "src/v8.h"
Expand Down

0 comments on commit 5f1157d

Please sign in to comment.