Version 5.8.213 #12
Closed
Version 5.8.213 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/5.8.213@{#1}
Cr-Branched-From: 7f6b823-refs/heads/master@{#43214}
danbev
pushed a commit
to danbev/v8
that referenced
this pull request
Feb 17, 2017
…tchset v8#12 id:220001 of https://codereview.chromium.org/2663803002/ ) Reason for revert: Breaks win64 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/14967 Original issue's description: > [string] Migrate String.prototype.{split,replace} to TF > > BUG= > > Review-Url: https://codereview.chromium.org/2663803002 > Cr-Commit-Position: refs/heads/master@{#42881} > Committed: https://chromium.googlesource.com/v8/v8/+/65ad1e35d9a97c1126a55cc9d3014598fd224259 TBR=bmeurer@chromium.org,ishell@chromium.org,yangguo@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2671673003 Cr-Commit-Position: refs/heads/master@{#42882}
|
This PR seems like a mistake to me. Closing. Please keep in mind that this is only a GitHub mirror of V8's 'real' repository. In order to submit changes please follow the instructions at https://github.com/v8/v8/wiki/Contributing. |
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Revision: cbb7145 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=hablich@chromium.org Review-Url: https://codereview.chromium.org/2646073003 . Cr-Commit-Position: refs/branch-heads/5.7@{#12} Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Revision: a4f37da BUG=chromium:654723 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/2415343002 . Cr-Commit-Position: refs/branch-heads/5.5@{#12} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged d944015 Merged 43d0b7e Merged 90fa326 Merged 7a02c72 Merged 9a9ffd1 Merged 21550e0 Merged bf4ef54 X87: [builtins] Introduce proper Float64Tan operator. X87: [cleanup] Remove dead code from DeclareLookupSlot and rename it. X87: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime. X87: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. X87: disable some sin/cos/expm1/tan test cases for x87. X87: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. X87: disable test-gap-resolver/FuzzResolver test case for x87. R=hablich@chromium.org BUG= LOG=N NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2127683002 Cr-Commit-Position: refs/branch-heads/5.3@{#12} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged 298ee9c Revert of [d8] Fix the shared-library build (patchset #12 id:20002 of https://codereview.chromium.org/2342563002/ ) BUG=chromium:646337 LOG=N R=hablich@chromium.org TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/2356713002 . Cr-Commit-Position: refs/heads/5.5.228@{#2} Cr-Branched-From: 2c10ca8-refs/heads/master@{#39503}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Revision: f3bf8f9 R=hablich@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2290603004 Cr-Commit-Position: refs/branch-heads/5.4@{#12} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged d0151bf [heap] Don't use black pages for map, code and, lo space. Instead color objects black. BUG=chromium:599174 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1899193005 . Cr-Commit-Position: refs/branch-heads/5.1@{#12} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged c268aea [turbofan] Unship try-catch. R=jkummerow@chromium.org, bmeurer@chromium.org BUG=v8:3566 LOG=Y Review URL: https://codereview.chromium.org/1768293002 . Cr-Commit-Position: refs/branch-heads/5.0@{#12} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
hubot
pushed a commit
that referenced
this pull request
Jul 26, 2017
…jects" This reverts commit b45c1c5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Merged: [regexp] Teach deoptimizer to materialize JSRegExp objects > > Revision: d8e1477 > > BUG=chromium:747825,v8:6556,v8:6605 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > TBR=jarin@chromium.org > > Change-Id: Ie3e68e53f13f28d3ea321a4ff9143eaec10fd787 > Reviewed-on: https://chromium-review.googlesource.com/584841 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/branch-heads/6.1@{#10} > Cr-Branched-From: 1bf2e10-refs/heads/6.1.534@{#1} > Cr-Branched-From: e825c43-refs/heads/master@{#46746} TBR=jarin@chromium.org,jgruber@chromium.org Change-Id: I32aca2f02b8e1dd1aed282ac4a4b3ec40eace3d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:747825, v8:6556, v8:6605 Reviewed-on: https://chromium-review.googlesource.com/585530 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/6.1@{#12} Cr-Branched-From: 1bf2e10-refs/heads/6.1.534@{#1} Cr-Branched-From: e825c43-refs/heads/master@{#46746}
hubot
pushed a commit
that referenced
this pull request
Sep 11, 2017
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8888f44df064901b243589dfc3367bec57894386 Reviewed-on: https://chromium-review.googlesource.com/660157 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.2@{#12} Cr-Branched-From: efa2ac4-refs/heads/6.2.414@{#1} Cr-Branched-From: a861ebb-refs/heads/master@{#47693}
hubot
pushed a commit
that referenced
this pull request
Oct 17, 2017
… bits). Revision: a803fad BUG=v8:6916 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Change-Id: I4236e37ee9693bed3f4bb65e43b33d8da94cf634 Reviewed-on: https://chromium-review.googlesource.com/722640 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#12} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
hubot
pushed a commit
that referenced
this pull request
Dec 12, 2017
…stores of small integers. Revision: f883485 BUG=chromium:791245 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Change-Id: I442c5c745df2e1c62f344945ba79f09033fcd6d5 Reviewed-on: https://chromium-review.googlesource.com/817440 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/branch-heads/6.4@{#12} Cr-Branched-From: 0407506-refs/heads/6.4.388@{#1} Cr-Branched-From: a5fc4e0-refs/heads/master@{#49724}
hubot
pushed a commit
that referenced
this pull request
Jan 30, 2018
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia11a67ab6370ac6eed031372c69d54a1a1d1ebc6 Reviewed-on: https://chromium-review.googlesource.com/891904 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.5@{#12} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
hubot
pushed a commit
that referenced
this pull request
Mar 7, 2018
TBR=machenbach@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3597d880c2e4987079ce9621b901e4effe0fd073 Reviewed-on: https://chromium-review.googlesource.com/951941 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.6@{#12} Cr-Branched-From: d500271-refs/heads/6.6.346@{#1} Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
hubot
pushed a commit
that referenced
this pull request
Apr 16, 2018
It is not safe to assume the first match is a string just because the RegExp result is fast. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: chromium:831943 Change-Id: Idd40f8b75312f0be54f45f626dc017339033abc6 Reviewed-on: https://chromium-review.googlesource.com/1009325 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#52578}(cherry picked from commit 7bdbe77) Reviewed-on: https://chromium-review.googlesource.com/1013578 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/branch-heads/6.7@{#12} Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2} Cr-Branched-From: e921be5-refs/heads/master@{#52547}
hubot
pushed a commit
that referenced
this pull request
Jun 4, 2018
TBR=machenbach@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia18671db3899c8428270d84dbff140643644d5c1 Reviewed-on: https://chromium-review.googlesource.com/1083982 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.8@{#12} Cr-Branched-From: 44d7d7d-refs/heads/6.8.275@{#1} Cr-Branched-From: 5754f66-refs/heads/master@{#53286}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 4, 2018
This reverts commit 52a10e5. Reason for revert: https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/12434/layout-test-results/results.html Crash e.g. in http/tests/devtools/oopif/oopif-performance-cpu-profiles.js crash log for devtools (pid <unknown>): STDOUT: <empty> STDERR: STDERR: STDERR: # STDERR: # Fatal error in ../../v8/src/compilation-dependencies.cc, line 281 STDERR: # Debug check failed: descriptor == owner->LastAdded() (10 vs. 22). STDERR: # STDERR: # STDERR: # STDERR: #FailureMessage Object: 0x7fff86878630#0 0x0000031c642c base::debug::StackTrace::StackTrace() STDERR: #1 0x0000046a56bb gin::(anonymous namespace)::PrintStackTrace() STDERR: v8#2 0x00000469c528 V8_Fatal() STDERR: v8#3 0x00000469c285 v8::base::(anonymous namespace)::DefaultDcheckHandler() STDERR: v8#4 0x000001cc5253 v8::internal::CompilationDependencies::DependOnFieldType() STDERR: v8#5 0x000001cdcc46 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfo() STDERR: v8#6 0x000001cde661 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfos() STDERR: v8#7 0x000001dd982b v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccess() STDERR: v8#8 0x000001ddb715 v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccessFromNexus() STDERR: v8#9 0x000001dd656d v8::internal::compiler::JSNativeContextSpecialization::ReduceJSLoadNamed() STDERR: v8#10 0x000001d53872 v8::internal::compiler::GraphReducer::Reduce() STDERR: v8#11 0x000001d534a5 v8::internal::compiler::GraphReducer::ReduceTop() STDERR: v8#12 0x000001d52e58 v8::internal::compiler::GraphReducer::ReduceNode() STDERR: v8#13 0x000001e4c201 v8::internal::compiler::InliningPhase::Run() STDERR: v8#14 0x000001e44f79 v8::internal::compiler::PipelineImpl::Run<>() STDERR: v8#15 0x000001e41058 v8::internal::compiler::PipelineImpl::CreateGraph() STDERR: v8#16 0x000001e40c75 v8::internal::compiler::PipelineCompilationJob::PrepareJobImpl() STDERR: v8#17 0x000001ccd437 v8::internal::OptimizedCompilationJob::PrepareJob() STDERR: v8#18 0x000001cd071e v8::internal::(anonymous namespace)::GetOptimizedCode() STDERR: v8#19 0x000001cd0c6f v8::internal::Compiler::CompileOptimized() STDERR: v8#20 0x00000231fb62 v8::internal::__RT_impl_Runtime_CompileOptimized_Concurrent() STDERR: v8#21 0x00000288e535 <unknown> Original change's description: > [turbofan] Rewrite CompilationDependencies > > Instead of installing code dependencies during graph reduction, > install them after code generation. > > Bug: v8:7902, v8:7790 > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > Reviewed-on: https://chromium-review.googlesource.com/1119913 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54170} TBR=mstarzinger@chromium.org,jarin@chromium.org,neis@chromium.org Change-Id: Ic58c2bfadbd34bb6ba7dc0d2b74871cc90b0a74f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7902, v8:7790 Reviewed-on: https://chromium-review.googlesource.com/1125680 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54192}
hubot
pushed a commit
that referenced
this pull request
Jul 25, 2018
TBR=machenbach@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3b85edfc96d3b612f8a0c35aa6b82359104a1971 Reviewed-on: https://chromium-review.googlesource.com/1150408 Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6.9@{#12} Cr-Branched-From: d7b61ab-refs/heads/6.9.427@{#1} Cr-Branched-From: b7e108d-refs/heads/master@{#54504}
peterwmwong
pushed a commit
to peterwmwong/v8
that referenced
this pull request
Dec 9, 2018
This reverts commit caed2cc. Reason for revert: Breaks layout tests, e.g. https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/14924/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: STDERR: STDERR: # STDERR: # Fatal error in ../../v8/src/base/platform/elapsed-timer.h, line 24 STDERR: # Debug check failed: !IsStarted(). STDERR: # STDERR: # STDERR: # STDERR: #FailureMessage Object: 0x7ffc46707640#0 0x565409263b6f base::debug::StackTrace::StackTrace() STDERR: #1 0x56540a8a32fb gin::(anonymous namespace)::PrintStackTrace() STDERR: #2 0x56540a8980d8 V8_Fatal() STDERR: #3 0x56540a897e35 v8::base::(anonymous namespace)::DefaultDcheckHandler() STDERR: v8#4 0x565407971f02 v8::base::ElapsedTimer::Start() STDERR: v8#5 0x565407d08edf v8::internal::TimedHistogram::Start() STDERR: v8#6 0x565407e500d5 v8::internal::IncrementalMarking::AdvanceIncrementalMarkingOnAllocation() STDERR: v8#7 0x565407e4f977 v8::internal::IncrementalMarking::Observer::Step() STDERR: v8#8 0x565407e48092 v8::internal::AllocationObserver::AllocationStep() STDERR: v8#9 0x565407eb0751 v8::internal::SpaceWithLinearArea::InlineAllocationStep() STDERR: v8#10 0x565407eb3e44 v8::internal::NewSpace::EnsureAllocation() STDERR: v8#11 0x565407e258ff v8::internal::NewSpace::AllocateRaw() STDERR: v8#12 0x565407e06b2d v8::internal::Heap::AllocateRaw() STDERR: v8#13 0x565407e432ef v8::internal::Heap::AllocateRawWithLightRetry() STDERR: v8#14 0x565407e433cf v8::internal::Heap::AllocateRawWithRetryOrFail() STDERR: v8#15 0x565407e04d48 v8::internal::Factory::NewFixedArrayWithFiller() STDERR: v8#16 0x565407fd6339 v8::internal::HashTable<>::New() STDERR: v8#17 0x565407fd7be8 v8::internal::HashTable<>::EnsureCapacity() STDERR: v8#18 0x565407fc7e95 v8::internal::Dictionary<>::Add() STDERR: v8#19 0x565407fcf453 v8::internal::BaseNameDictionary<>::Add() STDERR: v8#20 0x565407f89ee4 v8::internal::LookupIterator::ApplyTransitionToDataProperty() STDERR: v8#21 0x5654080036e2 v8::internal::Object::AddDataProperty() STDERR: v8#22 0x56540793061f v8::internal::(anonymous namespace)::DefineDataProperty() STDERR: v8#23 0x56540792da59 v8::internal::(anonymous namespace)::InstantiateObject() STDERR: v8#24 0x56540792b75a v8::internal::(anonymous namespace)::InstantiateFunction() STDERR: v8#25 0x56540792b4db v8::internal::ApiNatives::InstantiateFunction() STDERR: v8#26 0x5654079594bf v8::FunctionTemplate::GetFunction() STDERR: v8#27 0x56540a7af74e blink::V8ObjectConstructor::CreateInterfaceObject() STDERR: v8#28 0x56540a7afe01 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#29 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#30 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#31 0x56540a7afcb4 blink::V8PerContextData::CreateWrapperFromCacheSlowCase() STDERR: v8#32 0x56540a7aef73 blink::V8DOMWrapper::CreateWrapper() STDERR: v8#33 0x56540a7abf6b blink::ScriptWrappable::Wrap() STDERR: v8#34 0x56540a677199 blink::V8Document::documentElementAttributeGetterCallback() STDERR: v8#35 0x565407a0aec3 v8::internal::FunctionCallbackArguments::Call() STDERR: v8#36 0x565407a097be v8::internal::(anonymous namespace)::HandleApiCallHelper<>() STDERR: v8#37 0x565407a0877b v8::internal::Builtins::InvokeApiFunction() STDERR: v8#38 0x565407fe785a v8::internal::Object::GetPropertyWithAccessor() STDERR: v8#39 0x565407fe697e v8::internal::Object::GetProperty() STDERR: v8#40 0x565407ec8c71 v8::internal::LoadIC::Load() STDERR: v8#41 0x565407ed6401 v8::internal::__RT_impl_Runtime_LoadIC_Miss() STDERR: v8#42 0x5654087593f2 <unknown> STDERR: [16162:16185:1122/143518.356897:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ... Original change's description: > [heap] Improve embedder tracing during incremental marking > > Add a path into embedder tracing on allocation. This is safe as as Blink > is not allowed to call into V8 during object construction. > > Bug: chromium:843903 > Change-Id: I5af053c3169f5a33778ebce5d7c5c43e4efb1aa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1348749 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57757} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: Ide2c0b284b52bee17573adcc89f14be4e40dab91 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843903 Reviewed-on: https://chromium-review.googlesource.com/c/1349189 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57759}
junhuaw
pushed a commit
to junhuaw/v8
that referenced
this pull request
Feb 6, 2019
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ica10eb7c1b3ce27adfb9236497dd1eca2da30777 Reviewed-on: https://chromium-review.googlesource.com/c/1367884 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.2@{v8#12} Cr-Branched-From: 6acd03c-refs/heads/7.2.502@{#1} Cr-Branched-From: b03041d-refs/heads/master@{#57910}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Bug: chromium:1309225 Change-Id: Ic8184508503ee0099f5e7d0104ce68244c9827e0 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3550257 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/branch-heads/10.0@{v8#12} Cr-Branched-From: 6ea73a7-refs/heads/10.0.139@{#1} Cr-Branched-From: ccc6890-refs/heads/main@{#79131}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
1) Code in JSCallReducer read a FeedbackCell twice and expected the result to be the same. 2) JSInliningHeuristics, in the CheckClosure case, assumed that the FeedbackCell contains a FeedbackVector. (cherry picked from commit d90e873) Bug: chromium:1248743, v8:7790 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I66d6dd5f7a879c2479572e1896dd78aeedd2fa27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3162613 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/9.5@{v8#12} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: Icda95f09e9c4c903839f6d765de55c0060535458 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846152 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.6@{v8#12} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: 9e9d914 BUG=chromium:1292016 R=liviurau@chromium.org Change-Id: I8b482486e4e95591f941b61204c93273a4258e79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447362 Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/9.9@{v8#12} Cr-Branched-From: c4208cc-refs/heads/9.9.115@{#1} Cr-Branched-From: 19c6fd7-refs/heads/main@{#78682}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
…ted to module exports Revision: e4dba97 BUG=chromium:1260577 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=ishell@chromium.org Change-Id: Iab516d6edb15bf9965aa37f5a80956b0e9861bf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231340 Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/9.6@{v8#12} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Merged: [wasm] Fix return value of lazy compile runtime function Revision: 22a16bd Merged: [loong64][mips][wasm] Fix return value of lazy compile runtime function Revision: 7e50fa6 Merged: PPC/s390: [wasm] Fix return value of lazy compile runtime function Revision: 68ae81b Merged: [riscv64] Fix return value of lazy compile runtime function Revision: bdb2062 R=jkummerow@chromium.org Bug: chromium:1311960 Change-Id: I7556b2867051931029b0ede1aba5b5321d097c82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687697 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/10.2@{v8#12} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: If08fb926df2c4d828d22025f228bc8698687af2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3710108 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.4@{v8#12} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Merged: [ptr-cage] Fix Code by PC lookup Revision: 12dc338 Merged: [ptr-cage] Fix Code by PC lookup, pt.2 Revision: 4ee0a0a BUG=chromium:1241665,v8:11460 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Change-Id: I12b9af56e9bf0c7c49e8947b42e94c64a96d7391 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400971 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/9.8@{v8#12} Cr-Branched-From: e218afa-refs/heads/9.8.177@{#1} Cr-Branched-From: 86ebfc9-refs/heads/main@{#78312}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
This is a reland of b99fe75. The test is now skipped on non-SIMD hardware. Original change's description: > [liftoff][arm64] Zero-extend offsets also for SIMD > > This extends https://crrev.com/c/2917612 also for SIMD, which > (sometimes) uses the special {GetMemOpWithImmOffsetZero} method. > As part of this CL, that method is renamed to {GetEffectiveAddress} > which IMO is a better name. Also, it just returns a register to make the > semantic of that function obvious in the signature. > > Drive-by: When sign extending to 32 bit, only write to the W portion of > the register. This is a bit cleaner, and I first thought that > this would be the bug. > > R=jkummerow@chromium.org > CC=thibaudm@chromium.org > > Bug: chromium:1231950, v8:12018 > Change-Id: Ifaefe1f18e3a00534a30c99e3c37ed09d9508f6e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3049073 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75898} TBR=thibaudm@chromium.org (cherry picked from commit 5e90a61) Bug: chromium:1231950 Change-Id: Ie04cd1e1ae9e653d3774e381f89e4b29f14fb1f8 No-Try: true No-Tree-Checks: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059693 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/branch-heads/9.3@{v8#12} Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1} Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I9de26b1e86783768fc41ec704e1f5b24aabd3cda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289182 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/branch-heads/9.7@{v8#12} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
This reverts commit 82ce475. Reason for revert: trigger builders Original change's description: > Whitespace to trigger builders > > No-Try: true > No-Presubmit: true > No-Tree-Checks: true > Change-Id: I9de26b1e86783768fc41ec704e1f5b24aabd3cda > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289182 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/branch-heads/9.7@{v8#12} > Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} > Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674} Change-Id: I31afa1623dbf70835312cd87b8897d6416a204c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293087 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/9.7@{v8#13} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
LoadTransform is always a SIMD operation (it always results in a v128), so it should unconditionally set has_simd_. Bug: chromium:1137583 (cherry picked from commit 752aba9) Change-Id: I1af26eb472dce95ae31f53c74981c97278044243 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2473577 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/branch-heads/8.7@{v8#12} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
unicornx
pushed a commit
to unicornx/v8
that referenced
this pull request
Feb 16, 2023
Otherwise it's propagated to the parent Bug: chromium:1394973 (cherry picked from commit e1e0890) Change-Id: Id4e3059a79924c5056823af75688494cc531df40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4108029 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/10.9@{v8#12} Cr-Branched-From: 8ade6bf-refs/heads/10.9.194@{aosp-riscv#1} Cr-Branched-From: 9ff2515-refs/heads/main@{#84164}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
The expected behavior of the optimized code is deoptimizing when using a BigInt as an index and throwing an error (from CheckedTaggedToInt64). The representation changer tries to insert conversions for this case where - The output node is represented in Word64 (SignedBigInt64) - The use info is CheckedSigned64AsWord64 The representation changer first rematerializes the output node to TaggedPointer because the type check is not BigInt. Then it falls wrongly to the branch where the output representation is TaggedPointer, the output type is SignedBigInt64 in GetWord64RepresentationFor. (cherry picked from commit 6313496) Bug: v8:9407, chromium:1403574, chromium:1404607 Change-Id: I9d7ef4c94c1dc0aa3b4f49871ec35ef0877efc24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4135876 Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Qifan Pan <panq@google.com> Cr-Original-Commit-Position: refs/heads/main@{#85094} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4138619 Cr-Commit-Position: refs/branch-heads/11.0@{v8#12} Cr-Branched-From: 06097c6-refs/heads/11.0.226@{#1} Cr-Branched-From: 6bf3344-refs/heads/main@{#84857}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I78607d2045c768c55cc9e90b50d874c91b41b284 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4294521 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.2@{v8#12} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
We see crashes on arm64 on Windows. Disable the use of preserve_most there, until we figure out (and fix) the root cause. R=mlippautz@chromium.org (cherry picked from commit e33c3a0) Bug: chromium:1409934 Change-Id: I1f3b05dad6b2fa6f6c76a01a21c05f3c690c9fc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224502 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/branch-heads/11.1@{v8#12} Cr-Branched-From: c77793a-refs/heads/11.1.277@{#1} Cr-Branched-From: 95b79bf-refs/heads/main@{#85479}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
D8's implementation of `quit()` requires a special implementation of the `WasmAsyncResolvePromiseCallback`. So far this special implementation was the default implementation in V8, but it causes problems for other embedders, and it really is not a default implementation that should be copied by other embedders. So instead this CL reverts the DefaultWasmAsyncResolvePromiseCallback to an actual default implementation, and moves the special implementation needed by d8 to d8.cc. (cherry picked from commit 4dd3c6d) Change-Id: Iec1f3aa4253a820b97939b61f4ee0310f95b0f30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4487890 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#87339} Bug: chromium:1441887 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4502587 Commit-Queue: Abhijith Nair <abhijithnair@chromium.org> Cr-Commit-Position: refs/branch-heads/11.4@{v8#12} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Bug: v8:13647 Change-Id: Iefe061b35def8290e51d02537ea6a0f3b7da38f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4397687 Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/branch-heads/11.3@{v8#12} Cr-Branched-From: b0a3a06-refs/heads/11.3.244@{#1} Cr-Branched-From: 0326cf6-refs/heads/main@{#86647}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 13, 2023
The hole is not oddball anymore, but it should be still treated as essential object in the heap profiler. (cherry picked from commit 24347db) Bug: v8:14041, chromium:1453710 Change-Id: I867a12307163566d0eb646b16ba097839a4a313e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4590820 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#88088} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605000 Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#12} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jul 11, 2023
…ials Bug: v8:13917, chromium:1459545 (cherry picked from commit 030e148) Change-Id: I34c85bd72eef468e18a3595956ef6d6764e27e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4669544 Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/branch-heads/11.6@{v8#12} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Aug 27, 2023
No-Try: true Bug: chromium:1472354 Change-Id: I80498f94b77425730e4936b4e49ecd6795f9b2a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4813089 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/11.7@{v8#12} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Sep 24, 2023
…in AssembleMove Bug: v8:14334 (cherry picked from commit f233e69) Change-Id: I57778821773627ce93d488603cef74045a057688 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4885890 Commit-Queue: Lutz Vahl <vahl@chromium.org> Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/branch-heads/11.8@{v8#12} Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1} Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Nov 21, 2023
Merged: [maglev] Fix phi untagging skipping smi check Revision: 9e0df0b Merged: [maglev] Phi untagging fix Revision: 1a57a37 Merged: [maglev] Fix another phi untagging skipping smi check Revision: 5e88842 BUG=chromium:1499133,v8:7700 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=dmercadier@chromium.org Change-Id: I8231c3d9f5d94d3a2ac828e2674bf1579d8269fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5047532 Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/branch-heads/12.0@{v8#12} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Nov 21, 2023
Merged: [maglev] Fix phi untagging skipping smi check Revision: 9e0df0b Merged: [maglev] Phi untagging fix Revision: 1a57a37 Merged: [maglev] Fix another phi untagging skipping smi check Revision: 5e88842 BUG=chromium:1499133,v8:7700 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=dmercadier@chromium.org Change-Id: I585d3b3409d56b64ec6c83602829fd0510e6a2a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5049231 Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/branch-heads/11.9@{v8#12} Cr-Branched-From: 3eb7d73-refs/heads/11.9.169@{#1} Cr-Branched-From: 1a13bf9-refs/heads/main@{#90218}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Dec 10, 2023
…ffect Bug: v8:12783, chromium:1508367 (cherry picked from commit 9ccc063) Change-Id: If5d244e0caa493fc8ebb90fa3d43009607bb7295 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5103869 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/branch-heads/12.1@{v8#12} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Mar 5, 2024
…ffect free R=bmeurer@chromium.org (cherry picked from commit d01ae0d) Bug: 326117121 Change-Id: I6390bf672e5f3f5b881a0e8eedcb1080d6766824 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5343614 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/branch-heads/12.3@{#12} Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1} Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot
pushed a commit
that referenced
this pull request
Mar 25, 2024
Crash occurred because JSPI initialization was not completed if OT only. Moved all of init code to bootstrap phase; guarded both by OT & non-heap serialization (during snapshot) tests. Bug: chromium:330543313 (cherry picked from commit 1e59b8f) Change-Id: I4b7b7b727d67e939d2493e5ee84a8d3aad1585c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5393700 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/branch-heads/12.4@{#12} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
probablytom
pushed a commit
to probablytom/v8
that referenced
this pull request
Apr 11, 2024
Int64Lowering currently cannot deal with "elem_size_log2" scaling parameters, because AtomicWord32Pair doesn't support them. So the MachineOptimizationReducer shouldn't produce these parameters on this particular configuration. Fixed: chromium:1520311 (cherry picked from commit e0a43f2) Change-Id: I41c774068f62e07bca242e30dae5f6dd5998dd65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5239031 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/branch-heads/12.2@{v8#12} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
May 10, 2024
…perties Bug: 339458194 (cherry picked from commit f320600) Change-Id: Ic1cb6953060fcd63081dab88ff87eece3175aca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5526311 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/branch-heads/12.5@{#12} Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1} Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot
pushed a commit
that referenced
this pull request
May 22, 2024
A few of these should account for the possibility of the object not being a JSObject. Some of them were simply redundant. (cherry picked from commit fe67713) Bug: 339753685 Change-Id: I97dab098fb7024408a3d79934824b8e0316068ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5557062 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/branch-heads/12.6@{#12} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/5.8.213@{#1}
Cr-Branched-From: 7f6b823-refs/heads/master@{#43214}