Version 8.5.133 #42

zyadomer999 · 2020-06-08T21:06:57Z

Hello
I want to let you know that I have recently developed a function similar to Document.execCommand() with the latest javascript. As you might know, the mentioned function is obsolete and is subject to stop functioning on browsers, however, there is no alternative to it. Now I want to know if it is possible to implement the function I made into javascript source so that everyone can use it and do not waste their time on making it again.

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0d2b4571f655493bda2d915f374f59e092c85037 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235652 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/8.5.133@{#1} Cr-Branched-From: 3f064b5-refs/heads/master@{#68224}

googlebot · 2020-06-08T21:07:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jakobkummerow · 2020-06-08T21:10:18Z

V8 is not the right place for Document.execCommand or any similar functions.

The actual changes in this PR look like spam.

zyadomer999 · 2020-06-08T21:13:23Z

But I think everyone needs this function, I want to implement it into javascript as built in functions, can you help me please?

Resolve "ERROR: mfhc1 generated" Closes #42 See merge request swlab/swe/v8!60

Create CONTRIBUTING file

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ic52db5f33273158d14e81ab4d57384145c9764a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899249 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.8@{v8#42} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ifa48de3046f50ddb2b6d2426d68ad1f234fdcfdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906230 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#42} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}

Revision: 6516b1c BUG=chromium:1051017 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=hablich@chromium.org Change-Id: I0d4ea7d49f8ffc81c9b7d109df6ceccc9e159c6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056855 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/8.0@{v8#42} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}

This is a reland of f23f644 Fix the issue by wrap v8_executable("gen-regexp-special-case") inside if (current_toolchain == v8_generator_toolchain) { and change deps of action("run_gen-regexp-special-case") to ":gen-regexp-special-case($v8_generator_toolchain)", Original change's description: > Speed up CharacterRange::AddCaseEquivalents > > By using the lexCss("color:") to measure the performance > The change make the lexCss("color:") > x21 - x40 times faster than trunk. > x2.3 - x4.6 times faster than m74. > > Design Doc: http://shorturl.at/adfO5 > > Measured by out/x64.release/d8 reg977003.js > see reg977003.js attached to chromium:977003 > > Also see another cl of benchmark in > https://chromium-review.googlesource.com/c/v8/v8/+/1679651/ > > > Bug: chromium:977003 > Change-Id: Ie8518493d2c33df1594be1b4576bda715087b421 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674851 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62471} TBR=yangguo@chromium.org (cherry picked from commit 433403d) Bug: chromium:977003 Change-Id: Ib11000703a43632292e89579e609ecc0b8ae913d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683706 Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#62486} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1693830 Cr-Commit-Position: refs/branch-heads/7.6@{v8#42} Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1} Cr-Branched-From: 201c509-refs/heads/master@{#61902}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I8303d964c541bfa5b0bbbc392f64e4ed39f2ce9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080332 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.1@{v8#42} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}

…ool. Revision: d469c73 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: v8:10826 Change-Id: Ifcc532ee4195b188f4d5302d9ecdc4f23c28c563 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2374307 Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/8.5@{v8#42} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}

…t closures (cherry picked from commit 26df3fd) NOTRY=true Bug: chromium:1105318 Change-Id: I7b1c57b7ff7beaaa53c19a270d5a8c36b11baf17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301082 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#68903} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307178 Cr-Commit-Position: refs/branch-heads/8.4@{v8#42} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I667e1037de1f44e27322b99784bc80863db30aa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871395 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.1@{v8#42} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iaafe4e144c1699b9dba2365fbab942775e53ef32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038322 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.2@{v8#42} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I9b6ee1c91ed67d78a1cf12aa84051cfdf9eadfd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719824 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.9@{v8#42} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}

Bug: v8:12276 Change-Id: Id64e274151011edeaf092cba5bc5487118b3339a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205891 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Owners-Override: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/9.4@{v8#42} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}

Consider in-construction keys as live during the final GC pause. (cherry picked from commit 32a09a6) Bug: chromium:1259587 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ib1c490dcbc1d7e5a5b38947109fe0e8f7fe52002 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234198 Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/branch-heads/9.5@{v8#42} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}

Preparing for tail call is usually done by emitting the gap moves and then moving the stack pointer to its new position. An optimization consists in moving the stack pointer first and transforming some of the moves into pushes. In the attached case it looks like this (arm): 138 add sp, sp, v8#40 13c str r6, [sp, #-4]! 140 str r6, [sp, #-4]! 144 str r6, [sp, #-4]! 148 str r6, [sp, #-4]! 14c str r6, [sp, #-4]! ... 160 vldr d1, [sp - 4*3] The last line is a gap reload, but because the stack pointer was already moved, the slot is now below the stack pointer. This is invalid and triggers this DCHECK: Fatal error in ../../v8/src/codegen/arm/assembler-arm.cc, line 402 Debug check failed: 0 <= offset (0 vs. -12). A comment already explains that we skip the optimization if the gap contains stack moves to prevent this, but the code only checks for non-FP slots. This is fixed by replacing "source.IsStackSlot()" with "source.IsAnyStackSlot()": 108 vldr d1, [sp + 4*2] ... 118 str r0, [sp, #+36] 11c str r0, [sp, #+32] 120 str r0, [sp, #+28] 124 str r0, [sp, #+24] 128 str r0, [sp, #+20] ... 134 add sp, sp, v8#20 TBR=jgruber@chromium.org (cherry picked from commit 7506e06) Change-Id: I66ed6187755af956e245207e940c83ea0697a5e6 Bug: chromium:1137608 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505976 Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/8.6@{v8#42} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}

To make sure that Wasm memories don't exceed JSArrayBuffer size. This change shouldn't affect real-world modules, because finding enough contiguous address space to allocate that much memory is virtually impossible anyway. (cherry picked from commit 6d7ed2e) Fixed: chromium:1242339 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I6dfae2fbf7a5c4c038c2d32bfeb1c1420b5559b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338698 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/9.6@{v8#42} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Icb55f4e85b9d4e507cf47051c1f4e130e581826a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2840685 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.0@{v8#42} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}

Previously, StoreOwnIC incorrectly reuses the [[Set]] semantics when initializing public literal class fields and object literals in certain cases (e.g. when there's no feedback). This was less of an issue for object literals, but with public class fields it's possible to define property attributes while the instance is still being initialized, or to encounter existing static "name" or "length" properties that should be readonly. This patch fixes it by 1) Emitting code that calls into the slow stub when handling StoreOwnIC with existing read-only properties. 2) Adding extra steps in StoreIC::Store to handle such stores properly with [[DefineOwnProperty]] semantics. Bug: v8:12421, v8:9888 (cherry picked from commit 80bbbb1) Change-Id: I6547320a1caba58c66ee1043cd3183a2de7cefef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402435 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/branch-heads/9.7@{v8#42} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}

TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I967477cb400b3b5f39551c7c3bfec96da738fa38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528469 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.7@{v8#42} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}

Change-Id: Ic3279d60d91f4530554c4da2f2d94ffd876e54a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4081594 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#42} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}

Change-Id: Ie512c4f00062c05bb2a81db545ed343167fe29f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4490644 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.2@{v8#42} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}

Change-Id: I6cd921d684fb8c8800c9cd54c3bd6b77c1713096 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3954984 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.6@{v8#42} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}

This simplifies some call sites as they do not need to worry about stores to external pointer fields (especially lazily initialized ones) triggering GCs. This also keeps the sandbox and non-sandbox mode more consistent, as these stores will never trigger GC in non-sandbox builds. Since there must be millions of objects that own the external pointer table entries, the chances are quite high that GCs will anyway be scheduled. If not, we should instead see if we can introduce an API to only schedule incremental marking but not perform GC finalization. Bug: v8:13535 Cr-Commit-Position: refs/heads/main@{#84508} (cherry picked from commit 852aa18) Change-Id: I6e7b927ec722b7c9aff2fc6e620b70c94b29db41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086221 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/branch-heads/10.8@{v8#42} Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} Cr-Branched-From: 237de89-refs/heads/main@{#83672}

Change-Id: I5bf9489d7e866fe749a3d8b9f66e17543f385413 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855452 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.4@{v8#42} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}

(cherry picked from commit 6411212) Bug: chromium:1380063 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I6cffab1478388c9db560ecd5169d958db97c26d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4008363 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/branch-heads/10.7@{v8#42} Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1} Cr-Branched-From: 9521696-refs/heads/main@{#83201}

Change-Id: Ie324e1635e01895a4e6ccdc95cbbd3703c36ce82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605049 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.4@{v8#42} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}

Change-Id: I4b8d7bf3ad7b5a455595ca0398ffbd94b71e2719 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4726743 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#42} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}

Change-Id: I68bb08b3042d44eaa1218a7903206dea73a29abb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4902688 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.7@{v8#42} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}

Change-Id: I0e7ff2e9813c9675446206b0b254904b1c7f298b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5184758 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#42} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}

and: [wasm] Introduce new heap type 'imported string' (cherry picked from commit cfe1ccc) (cherry picked from commit 841c7c1) Fixed: b/326091470, b/324747822 Change-Id: Ia7ad389697b6a75d0af6d0130942b572e0243d73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5339904 Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/12.2@{#42} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}

… map had one If any previous map in the transition tree had an enum cache, then we recreate one when updating the map. (cherry picked from commit 807cf7d) Bug: b/330760873 Change-Id: I9c434486716055f9fab6dfe73d78e99b3a45b490 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5388435 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#92979} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5410318 Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/12.0@{#42} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}

jakobkummerow closed this Jun 8, 2020

ghost referenced this pull request in riscv-collab/v8 Jul 15, 2020

Merge branch '42-error-mfhc1-generated' into 'riscv-porting-dev'

b764677

Resolve "ERROR: mfhc1 generated" Closes #42 See merge request swlab/swe/v8!60

ghost pushed a commit to palmer-dabbelt/v8 that referenced this pull request Jul 22, 2020

Merge pull request v8#42 from v8-riscv/contributing

82d3490

Create CONTRIBUTING file

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 8.5.133 #42

Version 8.5.133 #42

zyadomer999 commented Jun 8, 2020

googlebot commented Jun 8, 2020

jakobkummerow commented Jun 8, 2020

zyadomer999 commented Jun 8, 2020

Version 8.5.133 #42

Version 8.5.133 #42

Conversation

zyadomer999 commented Jun 8, 2020

googlebot commented Jun 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

jakobkummerow commented Jun 8, 2020

zyadomer999 commented Jun 8, 2020