Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto accept previous year units #322

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Conversation

Incompleteusern
Copy link
Contributor

Fixes #300 #318.

Automatically accepts petitions of a user that has students of another instance with that unit unlocked.

@vEnhance
Copy link
Owner

Some changes requested:

  1. There's some random print statements that need to be fixed
  2. I think this is an O(n) query where n is the number of times you've done OTIS, but it really should be O(1). Django should support something like Student.objects.filter(user=student.user, curriculum__<something>=unit), I don't know off my head but I'd be shocked if it didn't exist.
  3. Needs unit tests.

@vEnhance
Copy link
Owner

thanks, can we actually just delete the stale lines rather than comment them out

@vEnhance
Copy link
Owner

still waiting on unit tests here

@jatloe
Copy link
Contributor

jatloe commented Apr 8, 2024

is this dead

@Incompleteusern
Copy link
Contributor Author

I don't feel like working on this right now. I might finish unit tests when this OTIS semester is over.

@coveralls
Copy link

coveralls commented Jul 27, 2024

Pull Request Test Coverage Report for Build 10127134543

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.779%

Totals Coverage Status
Change from base Build 10125073972: 0.02%
Covered Lines: 6757
Relevant Lines: 7210

💛 - Coveralls

@Incompleteusern
Copy link
Contributor Author

Unit Tests should be done.

@vEnhance vEnhance merged commit 8c2aa86 into vEnhance:main Jul 28, 2024
3 checks passed
@chessisdabest
Copy link

Wonderful timing for the new year...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-Unlock previous year units
5 participants