Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small typo and cleanup in README !minor #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

znegva
Copy link

@znegva znegva commented Jun 28, 2018

  • fixed typo (beautifu__ll__)
  • removed shields.io downloads-badge (seems no longer supported by pypi and/or shields.io)

- fixed typo (beautifu__ll__)
- removed shields.io downloads-badge (seems no longer supported by pypi and/or shields.io)
README.rst Outdated
Comment on lines 9 to 12
.. image:: https://img.shields.io/pypi/dm/gitchangelog.svg?style=flat
:target: https://pypi.python.org/pypi/gitchangelog/
:alt: Number of PyPI downloads

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change, shields.io downloads from pypi is working fine

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, but this MR is already 1,5 years old, no hope it will be merged ;)

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d72a0f0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   88.45%           
=========================================
  Files             ?        2           
  Lines             ?      840           
  Branches          ?      168           
=========================================
  Hits              ?      743           
  Misses            ?       58           
  Partials          ?       39           
Impacted Files Coverage Δ
src/gitchangelog/gitchangelog.py 88.34% <0.00%> (ø)
src/gitchangelog/gitchangelog.rc.reference.v2.1.3 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72a0f0...f846f65. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants