Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#126 and #127 done #128

Merged
merged 3 commits into from
May 28, 2020
Merged

#126 and #127 done #128

merged 3 commits into from
May 28, 2020

Conversation

vaadin-miki
Copy link
Owner

default class name for the TextField inside number fields

also, when setting id of number fields the TextField inside will have its id changed to belongs-to-whatever-id-was-set-to-number-field

closes #126
closes #127

@sonarcloud
Copy link

sonarcloud bot commented May 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@vaadin-miki
Copy link
Owner Author

closes #129

@vaadin-miki vaadin-miki linked an issue May 28, 2020 that may be closed by this pull request
Run Sonar with Java 11 #129
Closed
@vaadin-miki vaadin-miki merged commit b833449 into development May 28, 2020
@vaadin-miki vaadin-miki deleted the 126-127-number-fields-styling-and-id branch May 28, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Sonar with Java 11 WithIdMixin is missing from number fields Number fields cannot be easily styled
1 participant
@vaadin-miki