Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to set keyboard shortcuts for dialog actions #42

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

Legioth
Copy link
Member

@Legioth Legioth commented Aug 27, 2020

Fixes #12

@Artur-
Copy link
Member

Artur- commented Aug 27, 2020

Looks good but pressing enter when "cancel" is focused should probably not show "Accepted"

@Legioth
Copy link
Member Author

Legioth commented Aug 28, 2020

Fixed by preventing Enter keypress from bubbling out from buttons

@Artur- Artur- merged commit 045e576 into vaadin:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do I create a dialog with ENTER/ESC keyboard controls
2 participants