Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to Lumo Colors #3085

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix broken link to Lumo Colors #3085

merged 2 commits into from
Dec 19, 2023

Conversation

rodolforfq
Copy link
Contributor

The "Lumo Colors" link at https://vaadin.com/docs/latest/styling/lumo/lumo-variants redirects to https://vaadin.com/styling/lumo/lumo-style-properties/color which results in a 404 error. The corrected link now takes you to the correct page: https://vaadin.com/docs/latest/styling/lumo/lumo-style-properties/color

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the Language unchecked English language check has not been done label Dec 19, 2023
Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing 👍

@jouni jouni removed the Language unchecked English language check has not been done label Dec 19, 2023
@jouni jouni merged commit 9724ec7 into latest Dec 19, 2023
3 of 4 checks passed
@jouni jouni deleted the lumo-colors-broken-link-fix branch December 19, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants