Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions to disable component tracker #3095

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

mcollovati
Copy link
Contributor

@github-actions github-actions bot added the Language unchecked English language check has not been done label Dec 22, 2023
@mcollovati
Copy link
Contributor Author

Requires vaadin/flow#18355 to be merged

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
@mcollovati mcollovati marked this pull request as ready for review December 28, 2023 14:20
@mcollovati mcollovati requested a review from tltv December 28, 2023 14:20
articles/configuration/properties.adoc Outdated Show resolved Hide resolved
@russelljtdyer russelljtdyer added Language checking English language checking is in progress and removed Language unchecked English language check has not been done labels Jan 10, 2024
@russelljtdyer russelljtdyer added Language checked English language check done and removed Language checking English language checking is in progress labels Jan 10, 2024
@tarekoraby
Copy link
Contributor

Please consider re-targeting this PR to branch next, or remember to cherry-pick to next.

@mshabarov mshabarov merged commit cead99f into latest Jan 11, 2024
4 of 5 checks passed
@mshabarov mshabarov deleted the docs/disable_componenttracker branch January 11, 2024 09:00
mcollovati added a commit that referenced this pull request Jan 11, 2024
* docs: add instructions to disable component tracker

Part of vaadin/flow#18130

* Apply suggestions from code review

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>

* apply review suggestions

* First pass at editing touched files.

* Second pass at editing touched files.

---------

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov added a commit that referenced this pull request Jan 12, 2024
* docs: add instructions to disable component tracker

Part of vaadin/flow#18130

* Apply suggestions from code review



* apply review suggestions

* First pass at editing touched files.

* Second pass at editing touched files.

---------

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flow Language checked English language check done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants