Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disable component tracker #18355

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

mcollovati
Copy link
Collaborator

Description

Adds a configuration parameter that allows developers to disable component tracking.

Fixes #18130

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Adds a configuration parameter that allows developers to
disable component tracking.

Fixes #18130
Copy link

github-actions bot commented Dec 22, 2023

Test Results

1 050 files  +1  1 050 suites  +1   1h 16m 26s ⏱️ + 1m 50s
6 758 tests +4  6 713 ✅ +4  45 💤 ±0  0 ❌ ±0 
7 069 runs  +1  7 013 ✅ +1  56 💤 ±0  0 ❌ ±0 

Results for commit 8a7b875. ± Comparison against base commit de4f5ed.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Dec 27, 2023
Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcollovati mcollovati merged commit 4a930bb into main Dec 28, 2023
26 checks passed
@mcollovati mcollovati deleted the issues/18130_componenttracker_disable_parameter branch December 28, 2023 14:19
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

rodolforfq pushed a commit that referenced this pull request Feb 8, 2024
Adds a configuration parameter that allows developers to
disable component tracking.

Fixes #18130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

ComponentTracker is very slow
3 participants