Fixing Kubernetes Kit documentation error for V24 #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds devmode.hostsAllowed property * Note->plaintext; add reasoning * First pass at editing. * Second pass at editing. --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> Co-authored-by: Russell J.T. Dyer <6652767+russelljtdyer@users.noreply.github.com>
* docs: add instructions to disable component tracker Part of vaadin/flow#18130 * Apply suggestions from code review Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> * apply review suggestions * First pass at editing touched files. * Second pass at editing touched files. --------- Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
* fix: add note on DefaultI18NProvider available since 24.3 * First pass at editing. * More edits --------- Co-authored-by: Russell J.T. Dyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
* Add navigation examples for hybrid apps * Add a Link component * First pass at editing. --------- Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
* docs: update data-provider article for item index provider Document how to make callback for an item index with lazy data binding. Related-to: vaadin/flow#18088 * docs: fix vale findings * First pass at editing. * Vale fix * Second full pass at editing. --------- Co-authored-by: Russell J.T. Dyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Russell JT Dyer <russelljtdyer@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
…(CP: latest) (#3131) * fix: set i18n header before modifying for login java example * Revert "fix: set i18n header before modifying for login java example" This reverts commit fb2db9a. * fix: set i18n header before modifying for login java example (#3124) * fix: set i18n header before modifying for login java example * Update src/main/java/com/vaadin/demo/component/login/LoginOverlayInternationalization.java Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
* Update hardcoded vaadin version to 24.3.3 * Update _vaadin-version.adoc --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
* docs: add note about AllowInert on RPC calls Adds a note about the usage of AllowInert annotation to allow RPC calls to components behind a modal dialog or component. Fixes vaadin/flow#17496 * First pass at editing. * Second pass -- edited rest of document touched. --------- Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com>
* Update hardcoded vaadin version to 24.3.4 * Update _vaadin-version.adoc --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
* Update hardcoded vaadin version to 24.3.6 * Update _vaadin-version.adoc --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
* Update hardcoded vaadin version to 24.3.7 * Update _vaadin-version.adoc --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
The text "to observe the frontend" is already a part of the link - no need to repeat it
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
github-actions
bot
added
the
Language unchecked
rodolforfq
changed the title
* Update hardcoded vaadin version to 24.3.9 * update flow version --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
|
Shouldn't this be based on the 'next' branch, not the 'latest'? |
russelljtdyer
removed
the
Language unchecked
HasRouteParameters interface does not exist, the correct name is HasUrlParameter. Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
|
The relevant changes need to be reapplied on top of the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3308 for V24 (latest) branch.