-
Notifications
You must be signed in to change notification settings - Fork 103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 48 of 48 files at r1.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 276 at r1 (raw file):
Styles included this way may cause issues with web components. [[foot-3]] . The `@JavaScript` annotation can also be used in Vaadin 14 with npm. The V14 `/frontend` folder should then be used.
Why are StyleSheet
and JavaScript
removed from docs since they have not been removed nor deprecated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 217 at r1 (raw file):
[[foot-2]]
Seems that should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @manolo)
documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 217 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
[[foot-2]]
Seems that should be removed
Missed that , thanks.
documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 276 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Why are
StyleSheet
andJavaScript
removed from docs since they have not been removed nor deprecated ?
Because these are footnotes.
This text is not standalone.
It's attached to the text in "Vaadin 10-13, Vaadin 14 in compatibility mode" section.
This section is completely removed.
So those references are broken : they don't belong to anything. So it has no sense to keep them at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all discussions resolved, 1 of 1 LGTMs obtained
Part of vaadin/flow#6857
This change is