Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Drop bower and compatibility mode #1018

Merged
merged 9 commits into from
Jan 15, 2020
Merged

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Jan 13, 2020

Part of vaadin/flow#6857


This change is Reviewable

@manolo manolo added the fusion CCDM related documentations label Jan 15, 2020
@manolo manolo self-requested a review January 15, 2020 07:15
Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 48 of 48 files at r1.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)


documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 276 at r1 (raw file):

Styles included this way may cause issues with web components.
[[foot-3]]
. The `@JavaScript` annotation can also be used in Vaadin 14 with npm. The V14 `/frontend` folder should then be used.

Why are StyleSheet and JavaScript removed from docs since they have not been removed nor deprecated ?

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)


documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 217 at r1 (raw file):

[[foot-2]]

Seems that should be removed

Copy link
Author

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @manolo)


documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 217 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…
[[foot-2]]

Seems that should be removed

Missed that , thanks.


documentation/importing-dependencies/tutorial-ways-of-importing.asciidoc, line 276 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

Why are StyleSheet and JavaScript removed from docs since they have not been removed nor deprecated ?

Because these are footnotes.
This text is not standalone.
It's attached to the text in "Vaadin 10-13, Vaadin 14 in compatibility mode" section.
This section is completely removed.
So those references are broken : they don't belong to anything. So it has no sense to keep them at all.

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@manolo manolo merged commit 922e8af into ccdm Jan 15, 2020
@manolo manolo deleted the 6857-drop-bower-compatability branch January 15, 2020 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fusion CCDM related documentations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants