Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Bower support & compatibility mode in Flow 3.0+ #6857

Closed
8 tasks done
Artur- opened this issue Nov 7, 2019 · 3 comments
Closed
8 tasks done

Drop Bower support & compatibility mode in Flow 3.0+ #6857

Artur- opened this issue Nov 7, 2019 · 3 comments

Comments

@Artur-
Copy link
Member

Artur- commented Nov 7, 2019

Bower is included in Flow 2 for backwards compatibility with Flow 1. It should be removed from Flow 3.

  • Remove "compatibility mode"
  • Remove Bower build from the Maven plugin
  • Remove webjar support
    • Need to fix DnD mobile polyfills to be included in another way than now
  • Remove HTML import support
    • Remove theme translations for html imports
  • Remove frontend://
  • Remove features related to the Bower bundle, such as BundleDependencyFilter
  • Remove any Bower & webjar related documentation
  • Remove all OSGi related things (code & documentation)

Excluded:

  • Full updating of the migration documentation is not included in this ticket, only mentions to bower&webjars should be removed.
  • No need to add any documentation about updating to 15 as part of this ticket
@Artur- Artur- changed the title Drop Bower in Flow 3.0+ Drop Bower support in Flow 3.0+ Nov 7, 2019
@pleku pleku added this to Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Nov 29, 2019
@pleku pleku moved this from Inbox - needs triage to Product backlog in OLD Vaadin Flow ongoing work (Vaadin 10+) Dec 17, 2019
@pleku pleku changed the title Drop Bower support in Flow 3.0+ Drop Bower support & compatibility mode in Flow 3.0+ Dec 18, 2019
@pleku
Copy link
Contributor

pleku commented Dec 18, 2019

The point

Remove webjars support

would mean that our mobile dnd polyfill should be shipped as @NpmPackage & @JsModule.
Currently it is imported as npm-based webjar and added dynamically in DnDUtil.

@Artur-
Copy link
Member Author

Artur- commented Dec 18, 2019

Some old prototyping has been done here https://github.com/vaadin/flow/tree/proto-remove-bower

@Legioth
Copy link
Member

Legioth commented Dec 18, 2019

If I remember correctly, the mobile dnd polyfill is loaded as a "standard" webjar rather than through our custom webjar support. It is thus possible that it would keep working even if we'd remove our custom logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Vaadin Flow enhancements backlog (Vaa...
  
Done / Pending Release
Development

No branches or pull requests

4 participants