Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Remove/rewrite references to outdated router #12

Merged
merged 5 commits into from
Feb 14, 2018

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Feb 14, 2018

Fix for #2838


This change is Reviewable

@SomeoneToIgnore
Copy link
Contributor

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


src/main/java/com/vaadin/flow/tutorial/getstarted/ExampleTemplate.java, line 32 at r1 (raw file):

@HtmlImport("src/example-template.html")

You don't need to add it twice, don't you?


Comments from Reviewable

@denis-anisimov
Copy link
Author

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


src/main/java/com/vaadin/flow/tutorial/getstarted/ExampleTemplate.java, line 32 at r1 (raw file):

ExampleTemplate

partial copy/paste from the tutorial text
Done.


Comments from Reviewable

@SomeoneToIgnore
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/main/java/com/vaadin/flow/tutorial/getstarted/ExampleTemplate.java, line 32 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

ExampleTemplate

partial copy/paste from the tutorial text
Done.

Nice.


Comments from Reviewable

@SomeoneToIgnore SomeoneToIgnore merged commit 850ccfb into master Feb 14, 2018
@SomeoneToIgnore SomeoneToIgnore deleted the 2838-outdated-router branch February 14, 2018 10:14
@denis-anisimov denis-anisimov restored the 2838-outdated-router branch February 19, 2018 10:42
@denis-anisimov denis-anisimov deleted the 2838-outdated-router branch February 19, 2018 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants