-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: selection preservation mode api #5887
Merged
ugur-vaadin
merged 28 commits into
main
from
feat-add-api-for-enhanced-selection-on-refresh
Jan 15, 2024
Merged
feat: selection preservation mode api #5887
ugur-vaadin
merged 28 commits into
main
from
feat-add-api-for-enhanced-selection-on-refresh
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
force-pushed
the
feat-add-api-for-enhanced-selection-on-refresh
branch
2 times, most recently
from
January 4, 2024 11:56
66d6f10
to
bc61d77
Compare
ugur-vaadin
force-pushed
the
feat-add-api-for-enhanced-selection-on-refresh
branch
from
January 4, 2024 20:41
03a0ab8
to
1ca8090
Compare
ugur-vaadin
changed the title
feat: initial implementation of api for enhanced selection
feat: selection preserving strategy api
Jan 4, 2024
ugur-vaadin
changed the title
feat: selection preserving strategy api
feat: selection preservation strategy api
Jan 4, 2024
sissbruecker
reviewed
Jan 8, 2024
...n-flow-components-base/src/main/java/com/vaadin/flow/component/shared/DataChangeHandler.java
Outdated
Show resolved
Hide resolved
...ent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/CheckboxGroup.java
Outdated
Show resolved
Hide resolved
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Outdated
Show resolved
Hide resolved
...n-flow-components-base/src/main/java/com/vaadin/flow/component/shared/DataChangeHandler.java
Outdated
Show resolved
Hide resolved
...nents-base/src/main/java/com/vaadin/flow/component/shared/SelectionPreservationStrategy.java
Outdated
Show resolved
Hide resolved
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Outdated
Show resolved
Hide resolved
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Outdated
Show resolved
Hide resolved
...-radio-button-flow/src/main/java/com/vaadin/flow/component/radiobutton/RadioButtonGroup.java
Outdated
Show resolved
Hide resolved
...ent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/CheckboxGroup.java
Outdated
Show resolved
Hide resolved
...nents-base/src/main/java/com/vaadin/flow/component/shared/SelectionPreservationStrategy.java
Outdated
Show resolved
Hide resolved
ugur-vaadin
changed the title
feat: selection preservation strategy api
feat: selection preservation mode api
Jan 10, 2024
sissbruecker
approved these changes
Jan 10, 2024
ugur-vaadin
force-pushed
the
feat-add-api-for-enhanced-selection-on-refresh
branch
from
January 10, 2024 11:05
2bbb57b
to
8ae2c59
Compare
ugur-vaadin
force-pushed
the
feat-add-api-for-enhanced-selection-on-refresh
branch
from
January 15, 2024 11:48
8ae2c59
to
b912379
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 7 New issues |
ugur-vaadin
deleted the
feat-add-api-for-enhanced-selection-on-refresh
branch
January 15, 2024 12:32
This ticket/PR has been released with Vaadin 24.4.0.alpha2 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new API to provide the following 3 selection preservation mode options:
for the following 4 components:
The default modes are the same as before in order to not cause breaking changes.
The API is on the component level, and is controlled by setting an enum
SelectionPreservationMode
using:setSelectionPreservationMode(SelectionPreservationMode)
getSelectionPreservationMode
Fixes #5744
Type of change
Checklist
Additional for
Feature
type of change