Skip to content

Commit

Permalink
chore: removed com.vaadin.flow.server.startup.ServletVerifier from Se…
Browse files Browse the repository at this point in the history 
…rvletContainerInitializer
  • Loading branch information
@MarcinVaadin
MarcinVaadin committed Aug 24, 2022
1 parent 4419c0e commit 234a634
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion flow-server/src/main/resources/META-INF/services/jakarta.servlet.ServletContainerInitializer
View file
@@ -1,5 +1,4 @@
com.vaadin.flow.server.startup.LookupServletContainerInitializer
com.vaadin.flow.server.startup.ServletVerifier
com.vaadin.flow.server.startup.RouteRegistryInitializer
com.vaadin.flow.server.startup.ErrorNavigationTargetInitializer
com.vaadin.flow.server.startup.AnnotationValidator
Expand Down

8 comments on commit 234a634

@lpdevit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, is it possible to have an alpha2 release with this fix? Otherwise it won't work in Tomcat as a war... Thank you! https://discord.com/channels/732335336448852018/1009201939092865084/threads/1029109178880495756

@MarcinVaadin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forwarding question to @mshabarov

@mstahv
Copy link
Member

@mstahv mstahv commented on 234a634 Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting here as well in addition to the discord chat: you today use 24.0-SNAPSHOT as the flow-bom version to get forward.

But a thumb up for cutting new alpha. Numbers are free and it will be easier to track issues as they start to come up.

@lpdevit
Copy link

@lpdevit lpdevit commented on 234a634 Oct 11, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again Matti for your blazing fast help!
Looking forward to a new release of Vaadin 24

Have a nice day

@mstahv
Copy link
Member

@mstahv mstahv commented on 234a634 Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At your service 🙇‍♂️ Now waiting for all possible bug reports related to the jakarta hassle :-)

@mshabarov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpdevit I was trying to merge latest changes from Flow master into 24.0 and then make next alpha, but it takes more efforts than I thought. Thus, I will make next alpha2 without it and then release alpha3 once I get it merged.
I had one issue regarding maven stage plugin during alpha2 deployment. Should be fixed soon. I'll let you know when Flow 24.0.0.alpha2 is ready.

@lpdevit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpdevit I was trying to merge latest changes from Flow master into 24.0 and then make next alpha, but it takes more efforts than I thought. Thus, I will make next alpha2 without it and then release alpha3 once I get it merged. I had one issue regarding maven stage plugin during alpha2 deployment. Should be fixed soon. I'll let you know when Flow 24.0.0.alpha2 is ready.

Thank you so much Mikhail!

@mshabarov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpdevit flow 24.0.0.alpha2 is now available https://github.com/vaadin/flow/releases/tag/24.0.0.alpha2.

Please sign in to comment.