fix: do lazy initialization in a thread-safe way (#10456) (#10461)

fixes #9323
vaadin · Mar 30, 2021 · 2ff1566 · 2ff1566
1 parent 441bf7a
commit 2ff1566
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/flow-server/src/main/java/com/vaadin/flow/server/communication/UidlRequestHandler.java b/flow-server/src/main/java/com/vaadin/flow/server/communication/UidlRequestHandler.java
@@ -20,6 +20,7 @@
 import java.io.OutputStream;
 import java.io.StringWriter;
 import java.io.Writer;
+import java.util.concurrent.atomic.AtomicReference;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -55,7 +56,7 @@
 public class UidlRequestHandler extends SynchronizedRequestHandler
         implements SessionExpiredHandler {
 
-    private ServerRpcHandler rpcHandler;
+    private AtomicReference<ServerRpcHandler> rpcHandler = new AtomicReference<>();
 
     @Override
     protected boolean canHandleRequest(VaadinRequest request) {
@@ -151,11 +152,12 @@ public boolean handleSessionExpired(VaadinRequest request,
     }
 
     private ServerRpcHandler getRpcHandler(VaadinSession session) {
-        session.checkHasLock();
-        if (rpcHandler == null) {
-            rpcHandler = createRpcHandler();
+        ServerRpcHandler handler = rpcHandler.get();
+        if (handler == null) {
+            rpcHandler.compareAndSet(null, createRpcHandler());
+            handler = rpcHandler.get();
         }
-        return rpcHandler;
+        return handler;
     }
 
     /**