fix: do lazy initialization in a thread-safe way #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshabarov
approved these changes
Mar 29, 2021
vaadin-bot
reviewed
Mar 29, 2021
| @@ -184,11 +182,12 @@ public boolean handleSessionExpired(VaadinRequest request, | |||
| } | |||
|
|
|||
| private ServerRpcHandler getRpcHandler(VaadinSession session) { | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
|
Hi @denis-anisimov , this commit cannot be picked to 2.6 by this bot, can you take a look and pick it manually? |
|
Hi @denis-anisimov , this commit cannot be picked to 2.5 by this bot, can you take a look and pick it manually? |
denis-anisimov
pushed a commit
that referenced
this pull request
Mar 29, 2021
mshabarov
pushed a commit
that referenced
this pull request
Mar 29, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
denis-anisimov
pushed a commit
that referenced
this pull request
Mar 30, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9323