Skip to content

Commit

Permalink
chore: Maven and Gradle plugins should not be OSGi bundles (#12292)
Browse files Browse the repository at this point in the history
  • Loading branch information
Artur- committed Nov 11, 2021
1 parent 46a204f commit 582a48c
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 18 deletions.
24 changes: 23 additions & 1 deletion flow-plugins/flow-plugin-base/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@
<groupId>com.vaadin</groupId>
<artifactId>flow-plugins</artifactId>
<version>9.0-SNAPSHOT</version>

</parent>
<artifactId>flow-plugin-base</artifactId>

<properties>
<bnd.skip>false</bnd.skip>
</properties>

<dependencies>
<dependency>
<groupId>com.vaadin</groupId>
Expand Down Expand Up @@ -41,4 +44,23 @@
</dependency>

</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
<index>false</index>
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration>
</plugin>
</plugins>
</build>

</project>
20 changes: 3 additions & 17 deletions flow-plugins/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,9 @@
<module>flow-plugin-base</module>
<module>flow-maven-plugin</module>
</modules>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
<index>false</index>
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration>
</plugin>
</plugins>
</build>
<properties>
<bnd.skip>true</bnd.skip>
</properties>
<profiles>
<profile>
<id>gradle</id>
Expand Down

0 comments on commit 582a48c

Please sign in to comment.