Execute JS in the very end of the message processing event loop (#4459)

* Execute JS in the very end of the message processing event loop Fixes #4444 * Move JS execution via post flush listener after all listeners
vaadin · Aug 1, 2018 · 8ae9bd9 · 8ae9bd9
1 parent 471b67e
commit 8ae9bd9
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/flow-client/src/main/java/com/vaadin/client/communication/MessageHandler.java b/flow-client/src/main/java/com/vaadin/client/communication/MessageHandler.java
@@ -378,10 +378,14 @@ assert getServerId(valueMap) == -1
 
             if (json.hasKey(JsonConstants.UIDL_KEY_EXECUTE)) {
                 // Invoke JS only after all tree changes have been
-                // propagated
+                // propagated and after post flush listeners added during
+                // message processing (so add one more post flush listener which
+                // is called after all added post listeners).
                 Reactive.addPostFlushListener(
-                        () -> registry.getExecuteJavaScriptProcessor().execute(
-                                json.getArray(JsonConstants.UIDL_KEY_EXECUTE)));
+                        () -> Reactive.addPostFlushListener(() -> registry
+                                .getExecuteJavaScriptProcessor()
+                                .execute(json.getArray(
+                                        JsonConstants.UIDL_KEY_EXECUTE))));
             }
 
             Console.log("handleUIDLMessage: "