-
Notifications
You must be signed in to change notification settings - Fork 163
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add DOM listeners before attaching the element (#5195)
Fixes #5152
- Loading branch information
Showing
4 changed files
with
132 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...ts/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/DomListenerOnAttachView.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright 2000-2019 Vaadin Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.vaadin.flow.uitest.ui; | ||
|
|
||
| import com.vaadin.flow.component.dependency.HtmlImport; | ||
| import com.vaadin.flow.component.html.Div; | ||
| import com.vaadin.flow.dom.Element; | ||
| import com.vaadin.flow.router.Route; | ||
| import com.vaadin.flow.uitest.servlet.ViewTestLayout; | ||
|
|
||
| @Route(value = "com.vaadin.flow.uitest.ui.DomListenerOnAttachView", layout = ViewTestLayout.class) | ||
| @HtmlImport("frontend://com/vaadin/flow/uitest/ui/DomListenerOnAttach.html") | ||
| public class DomListenerOnAttachView extends AbstractDivView { | ||
| public DomListenerOnAttachView() { | ||
| Div status = new Div(); | ||
| status.setText("Waiting for event"); | ||
| status.setId("status"); | ||
|
|
||
| Element element = new Element("event-on-attach"); | ||
| element.addEventListener("attach", event -> { | ||
| status.setText("Event received"); | ||
| }); | ||
|
|
||
| getElement().appendChild(element, status.getElement()); | ||
| } | ||
| } |
35 changes: 35 additions & 0 deletions
35
...-root-context/src/main/webapp/frontend/com/vaadin/flow/uitest/ui/DomListenerOnAttach.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!-- | ||
| ~ Copyright 2000-2018 Vaadin Ltd. | ||
| ~ | ||
| ~ Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| ~ use this file except in compliance with the License. You may obtain a copy of | ||
| ~ the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, software | ||
| ~ distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| ~ WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| ~ License for the specific language governing permissions and limitations under | ||
| ~ the License. | ||
| --> | ||
| <!-- Using an absolute URL is a bad practice, but the nesting depth here makes it incovenient traverse up with ../.. --> | ||
| <link rel="import" href="/frontend/bower_components/polymer/polymer-element.html"> | ||
|
|
||
| <dom-module id="event-on-attach"> | ||
| <template> | ||
| Fires an event when attached | ||
| </template> | ||
| <script> | ||
| class EventOnAttach extends Polymer.Element { | ||
| static get is() { return 'event-on-attach' } | ||
|
|
||
| connectedCallback() { | ||
| super.connectedCallback(); | ||
|
|
||
| this.dispatchEvent(new CustomEvent('attach')); | ||
| } | ||
| } | ||
| customElements.define(EventOnAttach.is, EventOnAttach); | ||
| </script> | ||
| </dom-module> |
33 changes: 33 additions & 0 deletions
33
...ests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/DomListenerOnAttachIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright 2000-2018 Vaadin Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.vaadin.flow.uitest.ui; | ||
|
|
||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.openqa.selenium.By; | ||
|
|
||
| import com.vaadin.flow.testutil.ChromeBrowserTest; | ||
|
|
||
| public class DomListenerOnAttachIT extends ChromeBrowserTest { | ||
|
|
||
| @Test | ||
| public void filtering() { | ||
| open(); | ||
|
|
||
| String status = findElement(By.id("status")).getText(); | ||
| Assert.assertEquals("Event received", status); | ||
| } | ||
| } |