if simplification, javadoc fix

vaadin · Feb 28, 2022 · ebc775d · ebc775d
1 parent 19ed1c2
commit ebc775d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java b/flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
@@ -188,8 +188,8 @@ protected File getPackageLockFile() {
      * Gets the platform pinned versions that are not overridden by the user in
      * package.json.
      *
-     * @return JsonObject with the dependencies or empty JsonObject if file
-     *         doesn't exist
+     * @return {@code JsonObject} with the dependencies or empty
+     *         {@code JsonObject} if file doesn't exist
      * @throws IOException
      *             when versions file could not be read
      */

diff --git a/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdatePackages.java b/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdatePackages.java
@@ -152,8 +152,8 @@ boolean lockVersionForNpm(JsonObject packageJson, String versionsPath)
             }
         }
         for (String dependency : overridesSection.keys()) {
-            if (!(dependencies.hasKey(dependency)
-                    || devDependencies.hasKey(dependency))
+            if (!dependencies.hasKey(dependency)
+                    && !devDependencies.hasKey(dependency)
                     && overridesSection.getString(dependency).startsWith("$")) {
                 overridesSection.remove(dependency);
                 versionLockingUpdated = true;