Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

construct-style-sheets-polyfill should be dependency, not a dev dependency #10988

Closed
Artur- opened this issue May 14, 2021 · 4 comments · Fixed by #10991
Closed

construct-style-sheets-polyfill should be dependency, not a dev dependency #10988

Artur- opened this issue May 14, 2021 · 4 comments · Fixed by #10991
Labels
prerelease version for platform 20.0.0 prerelease version for platform 21.0.0 Released with Platform 14.6.2 Released with Platform 19.0.8 Released with Platform 20.0.0.beta2 Released with Platform 21.0.0.alpha2

Comments

@Artur-
Copy link
Member

Artur- commented May 14, 2021

construct-style-sheets-polyfill is imported by the theme generator, i.e. used runtime and not development time
Artur- added a commit that referenced this issue May 17, 2021
@Artur-
Change construct-style-sheets-polyfill to be a runtime dependency
6a5726d 
Fixes #10988
@Artur- Artur- mentioned this issue May 17, 2021
Merged
caalador pushed a commit that referenced this issue May 17, 2021
@Artur-
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
47aa845 
#10991)

Fixes #10988
vaadin-bot pushed a commit that referenced this issue May 17, 2021
@Artur- @vaadin-bot
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
94cce65 
#10991)

Fixes #10988
vaadin-bot pushed a commit that referenced this issue May 17, 2021
@Artur- @vaadin-bot
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
fbd2aec 
#10991)

Fixes #10988
caalador pushed a commit that referenced this issue May 17, 2021
@Artur- @caalador
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
fcbeba0 
#10991)

Fixes #10988
@caalador caalador mentioned this issue May 17, 2021
Merged
vaadin-bot added a commit that referenced this issue May 17, 2021
@vaadin-bot @Artur-
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
4755d3a 
#10991) (#10994)

Fixes #10988

Co-authored-by: Artur <artur@vaadin.com>
vaadin-bot added a commit that referenced this issue May 17, 2021
@vaadin-bot @Artur-
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
3b1392c 
#10991) (#10995)

Fixes #10988

Co-authored-by: Artur <artur@vaadin.com>
pleku pushed a commit that referenced this issue May 17, 2021
@caalador @Artur-
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
bf981d4 
#10991) (#10996)

Fixes #10988

Co-authored-by: Artur <artur@vaadin.com>
vaadin-bot pushed a commit that referenced this issue May 17, 2021
@caalador @Artur- @vaadin-bot
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
cd2db5e 
#10991) (#10996)

Fixes #10988

Co-authored-by: Artur <artur@vaadin.com>
vaadin-bot added a commit that referenced this issue May 17, 2021
@vaadin-bot @caalador @Artur-
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
fdcb31c 
#10991) (#10996) (#11006)

Fixes #10988

Co-authored-by: Artur <artur@vaadin.com>

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: Artur <artur@vaadin.com>
Artur- added a commit that referenced this issue May 18, 2021
@Artur-
fix: Change construct-style-sheets-polyfill to be a runtime dependency (
d3b2485 
#10991)

Fixes #10988
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 19.0.8. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.0.beta2. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha2. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.6.2. For prerelease versions, it will be included in its final version.

@caalador caalador mentioned this issue Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prerelease version for platform 20.0.0 prerelease version for platform 21.0.0 Released with Platform 14.6.2 Released with Platform 19.0.8 Released with Platform 20.0.0.beta2 Released with Platform 21.0.0.alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change construct-style-sheets-polyfill to be a runtime dependency vaadin/flow
2 participants
@Artur- @vaadin-bot