Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasStyle.addClassNames() doesn't handle multiple whitespaces #11709

Closed
mvysny opened this issue Sep 1, 2021 · 4 comments · Fixed by #11861
Closed

HasStyle.addClassNames() doesn't handle multiple whitespaces #11709

mvysny opened this issue Sep 1, 2021 · 4 comments · Fixed by #11861
Assignees
@mshabarov
Labels
bug Impact: High prerelease version for platform 22.0.0 Released with Platform 14.7.1 Released with Platform 20.0.8 Released with Platform 21.0.2 Released with Platform 22.0.0.alpha4 Severity: Minor
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@mvysny
Copy link
Member

mvysny commented Sep 1, 2021

Description of the bug / feature

new Div().addClassNames("   foo  bar    baz")

fails with

java.lang.IllegalArgumentException: Class name cannot be empty
	at com.vaadin.flow.internal.nodefeature.ElementClassList$ClassListView.validate(ElementClassList.java:45)
	at com.vaadin.flow.internal.nodefeature.ElementClassList$ClassListView.validate(ElementClassList.java:31)
	at com.vaadin.flow.internal.nodefeature.NodeList$SetView.add(NodeList.java:113)
	at com.vaadin.flow.internal.nodefeature.NodeList$SetView.add(NodeList.java:86)
	at com.vaadin.flow.component.HasStyle.addClassNames(HasStyle.java:144)

Expected behavior

The div should have three class names added.

Actual behavior

The code fails with an exception

Versions:

- Vaadin / Flow version: 14.6.8
- Java version: 8
@mshabarov mshabarov self-assigned this Sep 1, 2021
@mshabarov mshabarov added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Sep 1, 2021
@mshabarov mshabarov moved this from Needs triage to New P2 in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 1, 2021
@mshabarov mshabarov mentioned this issue Sep 15, 2021
Merged
9 tasks
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Sep 17, 2021
caalador pushed a commit that referenced this issue Sep 17, 2021
@mshabarov
fix: Handle an extra spaces in class names properly (#11861)
d319ea2 
Fixes #11709
vaadin-bot pushed a commit that referenced this issue Sep 17, 2021
@mshabarov @vaadin-bot
fix: Handle an extra spaces in class names properly (#11861)
4af39ea 
Fixes #11709
vaadin-bot pushed a commit that referenced this issue Sep 17, 2021
@mshabarov @vaadin-bot
fix: Handle an extra spaces in class names properly (#11861)
b0f9c48 
Fixes #11709
vaadin-bot pushed a commit that referenced this issue Sep 17, 2021
@mshabarov @vaadin-bot
fix: Handle an extra spaces in class names properly (#11861)
f8fca52 
Fixes #11709
vaadin-bot added a commit that referenced this issue Sep 17, 2021
@vaadin-bot @mshabarov
fix: Handle an extra spaces in class names properly (#11861) (#11881)
d275569 
Fixes #11709

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot added a commit that referenced this issue Sep 17, 2021
@vaadin-bot @mshabarov
fix: Handle an extra spaces in class names properly (#11861) (#11880)
aabc631 
Fixes #11709

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot added a commit that referenced this issue Sep 17, 2021
@vaadin-bot @mshabarov
fix: Handle an extra spaces in class names properly (#11861) (#11879)
83fa614 
Fixes #11709

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.2.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.1.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshabarov mshabarov

Labels
bug Impact: High prerelease version for platform 22.0.0 Released with Platform 14.7.1 Released with Platform 20.0.8 Released with Platform 21.0.2 Released with Platform 22.0.0.alpha4 Severity: Minor
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle an extra spaces in class names properly vaadin/flow
3 participants
@mvysny @vaadin-bot @mshabarov