Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to V21 causes an exception that node_modules cannot be removed #11794

Closed
Artur- opened this issue Sep 8, 2021 · 3 comments
Closed

Upgrading to V21 causes an exception that node_modules cannot be removed #11794

Artur- opened this issue Sep 8, 2021 · 3 comments
Assignees
@mshabarov
Labels
bug Impact: High Released with Platform 14.7.1 Released with Platform 20.0.8 Severity: Major
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@Artur-
Copy link
Member

Artur- commented Sep 8, 2021

Whenever a project with suitable npm dependencies is upgraded to V21, the launch fails with

Exception in thread "main" java.io.IOException: Unable to delete directory [.../]node_modules

The problem is that FileUtils.deleteDirectory in the used commons-io version is unable to delete folders with dangling symlinks. The dangling symlinks appear while deleting node_modules and the end result is that a bunch of files like regjsparser/node_modules/.bin/jsesc remain in node_modules after supposedly deleting everything.

The commons-io issue is https://issues.apache.org/jira/browse/IO-692

The fix would be to backport 250b6cc to 8.0
@mshabarov mshabarov mentioned this issue Sep 8, 2021
Merged
9 tasks
@mshabarov mshabarov added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Sep 8, 2021
@mshabarov mshabarov self-assigned this Sep 8, 2021
mshabarov added a commit that referenced this issue Sep 9, 2021
@mshabarov
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798)
f17109a 
Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794
vaadin-bot pushed a commit that referenced this issue Sep 9, 2021
@mshabarov @vaadin-bot
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798)
f8ee9b1 
Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794
vaadin-bot pushed a commit that referenced this issue Sep 9, 2021
@mshabarov @vaadin-bot
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798)
d3aad41 
Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794
vaadin-bot pushed a commit that referenced this issue Sep 9, 2021
@mshabarov @vaadin-bot
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798)
0c542fe 
Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794
vaadin-bot added a commit that referenced this issue Sep 9, 2021
@vaadin-bot @mshabarov
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798) (#11804)
80746ee 
Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot added a commit that referenced this issue Sep 10, 2021
@vaadin-bot @mshabarov
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798) (CP: 2.6) (…
63cb1a6 
…#11805)

* fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798)

Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794

* fix: IOUtils::toString doesn't throw exception anymore

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <mikhail@vaadin.com>
vaadin-bot added a commit that referenced this issue Sep 13, 2021
@vaadin-bot @mshabarov
fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798) (CP: 2.7) (…
dc04974 
…#11803)

* fix: bump commons-io from 2.8.0 to 2.11.0 (#11739) (#11798)

Bumps commons-io to a newer version where this bug has been fixed https://issues.apache.org/jira/browse/IO-692.

Fixes #11794

* fix: IOUtils::toString doesn't throw exception anymore

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <mikhail@vaadin.com>
@mshabarov
Copy link
Contributor

Backported.

OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Sep 20, 2021
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.1.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshabarov mshabarov

Labels
bug Impact: High Released with Platform 14.7.1 Released with Platform 20.0.8 Severity: Major
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Artur- @vaadin-bot @mshabarov