Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npx: the --ignore-existing argument has been removed. #11963

Closed
Artur- opened this issue Oct 1, 2021 · 2 comments · Fixed by #12406
Closed

npx: the --ignore-existing argument has been removed. #11963

Artur- opened this issue Oct 1, 2021 · 2 comments · Fixed by #12406
Labels
enhancement Released with Platform 22.0.2

Comments

@Artur-
Copy link
Member

Artur- commented Oct 1, 2021

Description of the bug / feature

Every build with V22 outputs

2021-10-01 14:02:19.138  INFO 91272 --- [onPool-worker-1] c.v.flow.server.frontend.FrontendTools   : using '/usr/local/bin/npx --yes --quiet --ignore-existing pnpm@5.18.10' for frontend package installation
npx: the --ignore-existing argument has been removed.
See `npm help exec` for more information

Minimal reproducible example

  1. vaadin init --pre hellov22
  2. cd hellov22
  3. mvn

Versions:

- Vaadin / Flow version: 22 alpha 5
@Artur-
Copy link
Member Author

Artur- commented Oct 13, 2021

https://github.com/npm/cli/blob/latest/docs/content/commands/npm-exec.md#compatibility-with-older-npx-versions

The npx binary was rewritten in npm v7.0.0, and the standalone npx
package deprecated at that time. npx uses the npm exec
command instead of a separate argument parser and install process, with
some affordances to maintain backwards compatibility with the arguments it
accepted in previous versions.

This resulted in some shifts in its functionality:
...

  • The --ignore-existing option is removed. Locally installed bins are
    always present in the executed process PATH.

Artur- added a commit that referenced this issue Nov 19, 2021
@Artur-
fix: Do not use --ignore-existing which is only available in npm 6
8b39d20 
While this might break some pnpm case, it will still help more to have consistent behavior across npm versions. Also the cases it might break are already broken for many users (npm 7+)

Fixes #11963
@Artur- Artur- mentioned this issue Nov 19, 2021
Merged
Artur- added a commit that referenced this issue Nov 19, 2021
@Artur-
fix: Do not use --ignore-existing which is only available in npm 6
7dd29cd 
While this might break some pnpm case, it will still help more to have consistent behavior across npm versions. Also the cases it might break are already broken for many users (npm 7+)

Fixes #11963
Artur- added a commit that referenced this issue Nov 23, 2021
@Artur-
fix: Do not use --ignore-existing which is only available in npm 6 (#…
f31ee2f 
…12406)

While this might break some pnpm case, it will still help more to have consistent behavior across npm versions. Also the cases it might break are already broken for many users (npm 7+)

Fixes #11963
joheriks pushed a commit that referenced this issue Dec 20, 2021
@Artur-
fix: Do not use --ignore-existing which is only available in npm 6 (#…
64b21c8 
…12406)

While this might break some pnpm case, it will still help more to have consistent behavior across npm versions. Also the cases it might break are already broken for many users (npm 7+)

Fixes #11963
@joheriks joheriks mentioned this issue Dec 20, 2021
Merged
joheriks pushed a commit that referenced this issue Dec 20, 2021
@Artur-
fix: Do not use --ignore-existing which is only available in npm 6 (#…
8e843bb 
…12406)

While this might break some pnpm case, it will still help more to have consistent behavior across npm versions. Also the cases it might break are already broken for many users (npm 7+)

Fixes #11963
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Released with Platform 22.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Do not use --ignore-existing which is only available in npm 6 vaadin/flow
3 participants
@Artur- @denis-anisimov @vaadin-bot