Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vite] Bundle compression for production bundles #12055

Closed
gilberto-torrezan opened this issue Oct 15, 2021 · 4 comments · Fixed by #12308
Closed

[Vite] Bundle compression for production bundles #12055

gilberto-torrezan opened this issue Oct 15, 2021 · 4 comments · Fixed by #12308
Assignees
@Artur-
Labels
enhancement prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2 vite Tickets related to vite support
Projects
Frontend build optimization

Comments

@gilberto-torrezan
Copy link
Contributor

How does it work today

The compression plugin is used in production builds to get a gzip bundle that can be served if supported by the requesting browser.

How could it work

We need to look into what Rollup or Vite plugins there are for the same thing. Requires investigation.
@gilberto-torrezan gilberto-torrezan added enhancement vite Tickets related to vite support labels Oct 15, 2021
@gilberto-torrezan gilberto-torrezan added this to To do in Frontend build optimization via automation Oct 15, 2021
@gilberto-torrezan
Copy link
Contributor Author

There are some plugins to deal with compression for the bundles, they need to be checked.

@gilberto-torrezan
Copy link
Contributor Author

We probably should support only Brotli instead of GZip with the new implementation.

@Artur-
Copy link
Member

Artur- commented Nov 3, 2021

https://github.com/alloc/vite-plugin-compress

@Artur- Artur- self-assigned this Nov 8, 2021
Artur- added a commit that referenced this issue Nov 8, 2021
@Artur-
feat: Gzip Vite output by default
9689a9d 
Fixes #12055
@Artur- Artur- mentioned this issue Nov 8, 2021
Merged
Artur- added a commit that referenced this issue Nov 8, 2021
@Artur-
feat: Gzip Vite output by default
037c7ea 
Fixes #12055
@gilberto-torrezan gilberto-torrezan moved this from To do to In progress in Frontend build optimization Nov 10, 2021
Artur- added a commit that referenced this issue Nov 10, 2021
@Artur-
feat: Compress Vite output by default in production
c10f9ec 
Uses Brotli and enables it by default

Fixes #12055
Artur- added a commit that referenced this issue Nov 10, 2021
@Artur-
feat: Compress Vite output by default in production
086fd83 
As Brotli is disabled by default, you need to enable it to use this feature.
#4740 will enable Brotli by default once server issues are sorted out

Fixes #12055
Frontend build optimization automation moved this from In progress to Done Nov 10, 2021
Artur- added a commit that referenced this issue Nov 10, 2021
@Artur-
feat: Compress Vite output by default in production (#12308)
48995df 
As Brotli is disabled by default, you need to enable it to use this feature.
#4740 will enable Brotli by default once server issues are sorted out

Fixes #12055
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Artur- Artur-

Labels
enhancement prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2 vite Tickets related to vite support
Projects
Frontend build optimization
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Compress Vite output by default in production vaadin/flow
3 participants
@Artur- @gilberto-torrezan @vaadin-bot