Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vite] Vite serves index.html directly when login view set in Spring Security configuration #12366

Closed
joheriks opened this issue Nov 16, 2021 · 1 comment · Fixed by #12382
Closed

[Vite] Vite serves index.html directly when login view set in Spring Security configuration #12366

joheriks opened this issue Nov 16, 2021 · 1 comment · Fixed by #12382
Assignees
@joheriks
Labels
bug prerelease version for platform 22.0.0 Released with Platform 22.0.0.rc1 vite Tickets related to vite support
Projects
Frontend build optimization

Comments

@joheriks
Copy link
Contributor

joheriks commented Nov 16, 2021 •
edited

Reproduction:

  • Check out https://github.com/vaadin/fusion-crm-tutorial
  • Update Vaadin version in pom.xml to 22.0-SNAPSHOT (2021-11-16 or newer, as 22.0.0.beta3 has an already fixed issue that prevents this bug from manifesting)
  • Run app and try to log in -> fails.
  • Notice that the bootstrap page source returned for /login is the plain index.html as returned by Vite, hence missing the CSRF token added by CsrfIndexHtmlRequestListener, and other things.

Flow should never serve index.html from Vite, as the bootstrap page must go through the IndexHtmlRequestHandler.
@joheriks joheriks added bug vite Tickets related to vite support labels Nov 16, 2021
@joheriks joheriks added this to To do in Frontend build optimization via automation Nov 16, 2021
@joheriks joheriks moved this from To do to In progress in Frontend build optimization Nov 16, 2021
@joheriks joheriks self-assigned this Nov 16, 2021
@joheriks joheriks mentioned this issue Nov 16, 2021
Closed
Artur- added a commit that referenced this issue Nov 17, 2021
@Artur-
fix: Make Vite not serve the index page for any route
1d87739 
Fixes #12366
@Artur- Artur- mentioned this issue Nov 17, 2021
Merged
Artur- added a commit that referenced this issue Nov 17, 2021
@Artur-
fix: Make Vite serve the index page only when using the exact URL
e6aaadf 
Fixes #12366
Artur- added a commit that referenced this issue Nov 17, 2021
@Artur-
fix: Make Vite serve the index page only when using the exact URL
c6fdf8a 
Fixes #12366
Artur- added a commit that referenced this issue Nov 17, 2021
@Artur-
fix: Make Vite serve the index page only when using the exact URL
c80d604 
Fixes #12366
Frontend build optimization automation moved this from In progress to Done Nov 18, 2021
joheriks pushed a commit that referenced this issue Nov 18, 2021
@Artur-
fix: Make Vite serve the index page only when using the exact URL of …
d12b98a 
…it (#12382)

Fixes #12366
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.rc1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joheriks joheriks

Labels
bug prerelease version for platform 22.0.0 Released with Platform 22.0.0.rc1 vite Tickets related to vite support
Projects
Frontend build optimization
Done
Milestone
No milestone
2 participants
@joheriks @vaadin-bot